Add option to return to build selection when crashing#2230
Open
vaisest wants to merge 1 commit into
Open
Conversation
LocalIdentity
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes issues where users encounter an issue which crashes PoB when loading. This is obviously not very common, but in cases such as #2217 can cause PoB to crash when loading, which renders both the dismiss and restart options useless. There can also be crashes in Draw functions, such as when it happened to timeless jewels at the start of 0.5 due to missing textures.
This option lets users at least continue using PoB without having to manually remove the problematic profile file, which they probably won't know to do.
Steps taken to verify a working solution:
error()to a tab's Draw methodLink to a build that showcases this PR:
https://pobb.in/wS-S5R5EYZfC (#2217 build which crashes)
Before screenshot:
After screenshot: