Support Vestige of Darkness physical damage to Chill/Freeze modifier#2250
Open
bct8925 wants to merge 1 commit into
Open
Support Vestige of Darkness physical damage to Chill/Freeze modifier#2250bct8925 wants to merge 1 commit into
bct8925 wants to merge 1 commit into
Conversation
Implements the unique helmet "Vestige of Darkness" (Tenebrous Crown) affix "Physical damage from Hits Contributes to Chill Magnitude and Freeze Buildup", which was previously unparsed. Adds a ModParser rule emitting the PhysicalCanChill and PhysicalCanFreeze flags, which the offence calc's canDoAilment() gate already uses to let a non-default damage type feed Chill magnitude and Freeze buildup. Updates the stale ModCache.lua entry (the line was cached as unrecognised) and adds a system spec covering the behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the Vestige of Darkness (Tenebrous Crown) unique helmet affix:
This modifier was previously unrecognised by the mod parser, so equipping the helmet had no effect on Chill or Freeze.
Changes
src/Modules/ModParser.lua— new rule emittingflag("PhysicalCanChill"),flag("PhysicalCanFreeze").src/Data/ModCache.lua— regenerated the stale cache entry for this line (it was cached as unrecognised, which shadowed the new parser rule).spec/System/TestAilments_spec.lua— new system test: a pure-physical Quarterstaff Strike has no Freeze buildup baseline, then gains Freeze buildup and Chill once the modifier is applied.Testing
FreezeBuildupAvg > 0and apply Chill; without it both remain zero.Reference build
Example build affected by this modifier: https://maxroll.gg/poe2/pob/4a65hh0h