Rework power stats #2261
Draft
vaisest wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2257.
Description of the problem being solved:
This PR reworks power stat reporting across the program. This is done by combining minion and player dps, and separating minion stats.
For example, previously we preferred player stats. This was problematic because e.g. avg damage on the tree wouldn't take minions into account at all. Then we preferred minion stats. This is confusing when searching for ehp on the tree.
This PR sums minion and player dps together. This isn't highly relevant because according to Local there is exactly one skill that needs this, but I think it is logical. The rest of the stats are clearly separated between player and minion. That means that if you e.g. play minion pact and PoB doesn't dynamically calculate the dps, you can now search for Minion Life on the tree, while being able to search player EHP without changing skills.
With the trader, it's now possible to do both at the same time. I.e. you can search for DPS + player EHP + a tiny bit of minion EHP.
This should also centralises the fetching of a power value to one function:
data.powerStatList.GetFromOutput(output, stat).This also makes the stat weight panel bigger, because it had no reason to be so annoyingly tiny
Steps taken to verify a working solution:
Tested:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: