Fix radius jewels only applying the first mod in the list#2264
Open
vaisest wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
I don't understand this modcache test. I regenerated it, but apparently the test's headless wrapper doesn't generate the very large radius line. No clue. Either way I don't see it being a real issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2260.
Description of the problem being solved:
It seems that radius jewels were only adding the first mod for each line. This meant that a mod such as ailment speed, which has one mod for each ailment type, only had the first mod applied. This fix is also applied for conquered radius jewels as they used the exactly same code
Steps taken to verify a working solution:
Link to a build that showcases this PR:
See #2260
Before screenshot:
After screenshot: