Skip to content

Add DOS Verify Done-Claims rule (gate agent done-claims on git ground truth)#311

Open
anthony-chaudhary wants to merge 2 commits into
PatrickJS:mainfrom
anthony-chaudhary:add-dos-verify-done-claims-rule
Open

Add DOS Verify Done-Claims rule (gate agent done-claims on git ground truth)#311
anthony-chaudhary wants to merge 2 commits into
PatrickJS:mainfrom
anthony-chaudhary:add-dos-verify-done-claims-rule

Conversation

@anthony-chaudhary

@anthony-chaudhary anthony-chaudhary commented Jun 13, 2026

Copy link
Copy Markdown

What

Adds rules/dos-verify-done-claims-cursorrules-prompt-file.mdc (and a Testing-section README entry) — a Cursor Project Rule that gates an AI agent's "done / shipped / fixed" claim on ground truth instead of the agent's own narration, using the deterministic DOS kernel (dos verify, dos commit-audit).

Why

When an agent says "done", that is a claim, not a fact — and a claim it checks by re-reading its own work is consistency, not grounding. A commit subject is forgeable (whoever wrote the message authored it); the files it touched are not (git did). This rule has Cursor confirm the claimed effect from git ancestry and the commit's actual diff before reporting work complete — catching a fix: that only touched a README, or a "tests pass" that deleted the assertions. It complements the existing PR Review / QA rules in the Testing section.

Format

  • Modern Cursor Project Rules .mdc with description / globs: **/* / alwaysApply: false frontmatter, matching the repository's format.
  • README entry added to ### Testing, alphabetically placed and following the existing link style.
  • The rule documents its boundaries: it checks did-the-claimed-thing-ship, not correctness (that is the test suite's job), and notes the dos verbs are read-only and pip install dos-kernel is the install (the PyPI name is dos-kernel, not the unrelated dos).

Summary by CodeRabbit

Release Notes

  • Documentation
    • Added new testing guidance for verifying completion claims against ground truth, ensuring reliable reporting of work status.
    • Updated testing section with reference to a verification mechanism that validates done/shipped/fixed claims through deterministic validation processes.

@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4be921ea-005c-4c27-8824-ac386647e4c0

📥 Commits

Reviewing files that changed from the base of the PR and between b044f95 and 672fa3b.

📒 Files selected for processing (2)
  • README.md
  • rules/dos-verify-done-claims-cursorrules-prompt-file.mdc

📝 Walkthrough

Walkthrough

This PR adds a new Cursor rule for deterministic verification of completion claims. A rule file is created that instructs agents to use DOS kernel commands to gate "done/shipped/fixed/passing" assertions against git ground truth. The README Testing section is updated with a single link entry for the new rule.

Changes

DOS Verify Done-Claims Rule

Layer / File(s) Summary
DOS verify rule definition and README entry
rules/dos-verify-done-claims-cursorrules-prompt-file.mdc, README.md
New rule file specifies mandatory DOS kernel verification commands (dos commit-audit, dos verify), exit code interpretation, handling of unwitnessed claims, and boundaries between evidence verification vs. correctness. README testing section links the new rule.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • PatrickJS

Poem

🐰 A kernel's truth cuts through the claims,
No more agent tales and reframing games,
DOS commands verify what was shipped,
Ground truth binds each promise that's gripped,
Done is done, when the evidence is whipped! 📋✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a DOS Verify Done-Claims rule that gates agent done-claims against git ground truth.
Description check ✅ Passed The description comprehensively covers all required sections from the template including summary, contribution type, value to users, files changed, and quality checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant