Cursor/homepage visual polish#2
Open
JaredPastor wants to merge 4 commits into
Open
Conversation
Adds static imagery and provider SVGs. Ignores Hugo public_test output and dev server logs so future diffs stay source-focused. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
agg23
reviewed
May 6, 2026
agg23
requested changes
May 7, 2026
agg23
left a comment
agg23
left a comment
Member
There was a problem hiding this comment.
I think you may have some unused images.
Let's talk about the logo in a different set of changes.
I generally like this though, I'm just nitpicking details.
| background: rgba(10, 10, 10, 0.92); | ||
| border: 1px solid var(--color-border); | ||
| border-radius: 999px; | ||
| box-shadow: 0 12px 36px rgba(255, 255, 255, 0.04); |
Member
There was a problem hiding this comment.
Same goes for the rest of the changes; the glows around buttons and such.
| .hero-preview-wrap { | ||
| width: 100%; | ||
| max-width: min(var(--layout-max-width), calc(100% - 2 * var(--layout-pad-inline))); | ||
| margin: clamp(1.75rem, 4vw, 2.75rem) auto 0; |
Member
There was a problem hiding this comment.
I don't understand why this is is variable. I think the vertical margin between this content and the buttons ("Get Started") should be larger.
| </div> | ||
| <div class="restore-list"> | ||
| <div class="restore-item"> | ||
| <span class="restore-item__watermark" aria-hidden="true"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" xmlns="http://www.w3.org/2000/svg"><path d="M12 2a3 3 0 0 0-3 3v7a3 3 0 0 0 6 0V5a3 3 0 0 0-3-3z"/><path d="M19 10v2a7 7 0 0 1-14 0v-2"/><line x1="12" x2="12" y1="19" y2="22"/><path d="M8 22h8"/></svg></span> |
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="control-grid"> |
Member
There was a problem hiding this comment.
I don't feel strongly about this, but I don't know that this is providing value.
| <section class="landing-section landing-section--requirements"> | ||
| <div class="section-copy"> | ||
| <p class="section-label">Requirements</p> | ||
| <h2>What you need to revive a Pin.</h2> |
Member
There was a problem hiding this comment.
Ideally this is shorter and flows better
| <article class="requirements-card"> | ||
| <span class="requirements-card__index" aria-hidden="true">02</span> | ||
| <h3 class="requirements-card__title">Interposer</h3> | ||
| <p class="requirements-card__body">You need an interposer that touches the debug pads hidden under the bottom sticker.</p> |
Member
There was a problem hiding this comment.
Link to interposer page and have a less weird description
| </article> | ||
| <article class="requirements-card"> | ||
| <span class="requirements-card__index" aria-hidden="true">03</span> | ||
| <h3 class="requirements-card__title">Chrome or Edge</h3> |
| @@ -0,0 +1,46 @@ | |||
| <div class="center-preview center-preview--hero"> | |||
| }); | ||
| } | ||
|
|
||
| var frame = document.querySelector('.origin-story-frame'); |
| @@ -0,0 +1,84 @@ | |||
| +++ | |||
Member
There was a problem hiding this comment.
I still don't understand why we need a timeline
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed up the style of some sections and reorganized the order of them as well