Closed
Conversation
|
This PR is over a year old with no comments or activity. I am considering committing to Perfect as a solution for a system I am working on and this stale PR is worrying to me. Can a maintainer chime in? |
Member
|
Hello, sorry for the lack of feedback on this. We had added the following quite a while ago and, in my opinion, it took care of this need: https://github.com/PerfectlySoft/Perfect-HTTP/blob/master/Sources/PerfectHTTP/TypedRoutes.swift#L89 It lets you decode the body in a more type-safe manner. I'm open-ish to adding what this PR proposes, but it seems a little redundant given the above. Thoughts? |
|
Thanks for the response, I wanted to gauge the pulse of the project. I agree this PR is no longer needed. Close it? |
Author
|
I'm ok with that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given how common json data is in POST requests; would be nice to it available without having to parse it yourself.
Accompanies PerfectlySoft/Perfect-HTTPServer#10