Update Space Engineers, pass appId as number, remove faudio and disable NVAPI workarround by Zemogiter · Pull Request #1119 · PhoenicisOrg/scripts

Zemogiter · 2019-09-08T12:40:56Z

Description

By using the PPA linked in the script, vanilla Space Engineers is nearly free of audio stutters. Introducing mods changes that for the worse but nothing we can do about that.

What works

Everything

What was not tested

Nothing

Test

Operating system (and linux kernel version): Ubuntu 19.04 5.0.0-27-generic
Hardware (GPU/CPU):
i7-7700K,GTX 1080 TI

Ready for review

Script tested as a regular phoenicis user and working (if you have a problem -> create as draft and ask for help).
json-align and eslint run according to the documentation.
Codacy and travis checked.

Applications/Games/Space Engineers/Steam/script.js

Turns out you don't need the dev package.

Using more standard const names and redid the faudio message to fit more scenarios.

Applications/Games/Space Engineers/Steam/script.js

Zemogiter · 2019-10-31T17:27:00Z

Blocked until #1137 is merged

Added a DXVK config file to disable NVAPI workarround for extra performance with mods.

Zemogiter · 2019-11-03T13:32:33Z

Blocked until #1138 is fixed.

Zemogiter · 2019-11-20T09:21:58Z

Ready for review.

madoar

@Zemogiter the script is tested?

Applications/Games/Space Engineers/Steam/script.js

Zemogiter · 2019-11-26T08:55:46Z

@madoar ~~can't test beause of PhoenicisOrg/phoenicis#2115 (comment)~~
UPDATE: @plata suggested mvn install before mvn exec:java and it helped. ~~But now I have this issue #1143 which prevent me from testing. But I know the game works because I've updated Lutris script to work practicly the same as this one.~~ See #1143 (comment)

Zemogiter · 2019-12-24T15:20:51Z

Blocked until #1148 is fixed

Changed the 1st message, updated wine version.

Part of disabling the nvapi workaround.

Zemogiter · 2020-01-01T17:01:36Z

OK so after all "blocked by x" or "blocked until x is fixed/merged" comments have been solved, I've copied the version of this script from this repo to a local one. Clicking "install" results in this error:

TypeError: undefined is not a function
	at <js> QuickScript(Unnamed:25:926-972)
	at <js> SteamScript(Unnamed:15:679-685)
	at <js> :program(Unnamed:12:492-508)
	at org.graalvm.polyglot.Context.eval(Context.java:370)
	at org.phoenicis.scripts.engine.implementation.PolyglotScriptEngine.evalAndReturn(PolyglotScriptEngine.java:73)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:834)

madoar · 2020-01-01T17:20:49Z

Can you locate where exactly this occurs?

Zemogiter · 2020-01-04T08:16:12Z

After all those commits the game is working and the only audio stutter is at the main menu for about 5 first seconds of the song. However that is present on Windows as well. Ready for review.

plata · 2020-01-13T18:14:16Z

@madoar would you like to review this (you requested the last changes)?

Zemogiter · 2020-01-14T11:58:29Z

Blocked until #1198 is merged.

Applications/Games/Space Engineers/Steam/script.js

Trailing spaces removal

DXVK documentation uses `=` characters not `:`

codacy fix

Applications/Games/Space Engineers/Steam/script.js

Using proper json format

plata · 2020-04-06T10:23:09Z

Applications/Games/Space Engineers/Steam/script.js

+    })
+    .executable("Steam.exe", ["-silent", "-applaunch", "244850", "-no-cef-sandbox", "-skipintro"])
+    .environment((wine) => {
+        const dxvkConfigFile = wine.prefixDirectory() + "/drive_c/dxvk.conf";


Issue found: 'dxvkConfigFile' is assigned a value but never used.

Zemogiter · 2020-05-12T08:51:55Z

I have a problem. Merging #1198 in local repo results in this error when verifying steam installer:

org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - TypeError: invokeMember (writeValue) on JavaObject[org.phoenicis.tools.config.CompatibleConfigFileFormat@3324f53a (org.phoenicis.tools.config.CompatibleConfigFileFormat)] failed due to: UnsupportedTypeException
	at <js> createContainer(Unnamed:359:13215-13271)
	at <js> prefix(Unnamed:79:2538-2603)
	at <js> go(Unnamed:129-131:7060-7201)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy67.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:830)

[WARNING] 
org.graalvm.polyglot.PolyglotException: TypeError: invokeMember (writeValue) on JavaObject[org.phoenicis.tools.config.CompatibleConfigFileFormat@3324f53a (org.phoenicis.tools.config.CompatibleConfigFileFormat)] failed due to: UnsupportedTypeException
    at <js>.createContainer (Unnamed:359)
    at <js>.prefix (Unnamed:79)
    at <js>.go (Unnamed:129)
    at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke (HostInteropReflect.java:678)
    at com.sun.proxy.$Proxy67.go (Unknown Source)
    at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7 (ApplicationInformationPanelSkin.java:237)
    at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval (PhoenicisInteractiveScriptSession.java:35)
    at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1 (BackgroundScriptInterpreter.java:45)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1128)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:628)
    at java.lang.Thread.run (Thread.java:830)

plata · 2020-05-14T16:27:55Z

It works if you do not use the .environment?

Zemogiter · 2020-05-14T17:33:07Z

@plata removed .environment from SE script, still crashes at the same point with the same message

plata · 2020-05-14T18:13:35Z

Then, how can it be related to #1198?

Zemogiter · 2020-05-14T18:32:31Z

Then I guess it's not.

Zemogiter · 2020-06-22T09:33:56Z

OK so I've removed any changes to QuickScript and SteamScript regarding environment() and pasted the changes from this PR to the local repo execpt the aforementioned environment(). Once I get to the step when the Steam installation should start, it dosen't and I get no error in terminal. It's stuck at "Please follow the steps of Steam installation...." message.

plata · 2020-06-22T16:52:31Z

Other Steam app installations work?

Zemogiter · 2020-06-24T12:35:27Z

Just tried the Space Colony steam script and the steam installer launched just fine.
UPDATE:
The script went though .preInstall() fine but upon launching steam again it crashed with this error:

[ERROR] org.phoenicis.multithreading.ControlledThreadPoolExecutorService (l.64) - /home/jonasz/.Phoenicis/containers/wineprefix/Space Colony/drive_c/Program Files/Steam/Steam.exe (no such file or directory)
	at java.base/java.io.FileInputStream.open0(Native Method)
	at java.base/java.io.FileInputStream.open(FileInputStream.java:212)
	at java.base/java.io.FileInputStream.<init>(FileInputStream.java:154)
	at org.phoenicis.tools.win32.ExeAnalyser.isArchitecture(ExeAnalyser.java:61)
	at org.phoenicis.tools.win32.ExeAnalyser.is64Bits(ExeAnalyser.java:46)
	at <js> run(Unnamed:407:15350-15396)
	at <js> run(Unnamed:172:5961-6051)
	at <js> runInsidePrefix(Unnamed:139:4721-4822)
	at <js> go(Unnamed:174:8729-8833)
	at com.oracle.truffle.polyglot.ObjectProxyHandler.invoke(HostInteropReflect.java:678)
	at com.sun.proxy.$Proxy68.go(Unknown Source)
	at org.phoenicis.javafx.components.application.skin.ApplicationInformationPanelSkin.lambda$installScript$7(ApplicationInformationPanelSkin.java:237)
	at org.phoenicis.scripts.session.PhoenicisInteractiveScriptSession.eval(PhoenicisInteractiveScriptSession.java:35)
	at org.phoenicis.scripts.interpreter.BackgroundScriptInterpreter.lambda$createInteractiveSession$1(BackgroundScriptInterpreter.java:45)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
	at java.base/java.lang.Thread.run(Thread.java:832)
Caused by host exception: java.io.FileNotFoundException: /home/jonasz/.Phoenicis/containers/wineprefix/Space Colony/drive_c/Program Files/Steam/Steam.exe (no such file or directory)

The issue is because its steam.exe not Steam.exe

plata · 2020-06-24T17:29:11Z

If the executable has been renamed, it must be changed in

scripts/Engines/Wine/QuickScript/Steam Script/script.js

Line 17 in dc0dd76

this._executable = "Steam.exe";

trailing spaces removal

Update script.js

3890172

plata requested changes Sep 9, 2019

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Outdated Show resolved Hide resolved

Zemogiter added 3 commits September 10, 2019 10:14

Update script.js

c4063b0

Update script.js

f8d24e5

Turns out you don't need the dev package.

Merge branch 'master' into patch-5

c2ec5ed

plata changed the title ~~Update Space Engineers, parsing appId as a number and removed faudio~~ Update Space Engineers, pass appId as number and remove faudio Sep 16, 2019

Zemogiter added 2 commits September 20, 2019 18:08

Update script.js

50b98e4

Using more standard const names and redid the faudio message to fit more scenarios.

Merge branch 'master' into patch-5

67c37af

madoar requested changes Oct 3, 2019

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Outdated Show resolved Hide resolved

Zemogiter added 2 commits October 4, 2019 12:36

Update script.js

6c60528

Update script.js

d33f6c3

madoar reviewed Oct 5, 2019

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Outdated Show resolved Hide resolved

Merge branch 'master' into patch-5

158baba

Update script.js

01282f7

Added a DXVK config file to disable NVAPI workarround for extra performance with mods.

Zemogiter changed the title ~~Update Space Engineers, pass appId as number and remove faudio~~ Update Space Engineers, pass appId as number, remove faudio and disable NVAPI workarround Nov 1, 2019

Zemogiter added 2 commits November 10, 2019 09:20

Update script.js

e93ad5a

Update script.js

17ec66a

madoar reviewed Nov 25, 2019

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Outdated Show resolved Hide resolved

madoar added the requires testing This Pull Request requires by a user that actually owns the software label Nov 25, 2019

Zemogiter added 4 commits December 24, 2019 16:53

Update script.js

4303a6a

Changed the 1st message, updated wine version.

Update script.js

cf9220b

Part of disabling the nvapi workaround.

Merge branch 'master' into patch-5

4f05ce9

Update script.js

1046714

Update script.js

9cdf1cf

Update script.js

e30a5d3

ImperatorS79 reviewed Jan 14, 2020

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Show resolved Hide resolved

Zemogiter added 6 commits January 14, 2020 13:03

Update script.js

7c10510

Update script.js

1f2ebae

Trailing spaces removal

Update script.js

79cedc2

DXVK documentation uses `=` characters not `:`

Update script.js

a6ea880

codacy fix

Update script.js

2a57699

Update script.js

bc0a40d

madoar requested changes Feb 8, 2020

View reviewed changes

Applications/Games/Space Engineers/Steam/script.js Outdated Show resolved Hide resolved

Update script.js

80bc907

Using proper json format

plata reviewed Apr 6, 2020

View reviewed changes

This was referenced May 12, 2020

Update Subnautica (use latest Wine devel version, disable nvapi workaround, set environment variables) #1197

Open

Can't login into Steam if virtual desktop is enabled #1209

Open

Zemogiter added 4 commits January 25, 2021 00:11

Merge branch 'master' into patch-5

203f50a

Update script.js

01f4d92

Update script.js

1afa0f1

Update script.js

2695d8d

trailing spaces removal

Conversation

Zemogiter commented Sep 8, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

What works

What was not tested

Test

Ready for review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zemogiter commented Oct 31, 2019

Uh oh!

Zemogiter commented Nov 3, 2019

Uh oh!

Zemogiter commented Nov 20, 2019

Uh oh!

madoar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Zemogiter commented Nov 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zemogiter commented Dec 24, 2019

Uh oh!

Zemogiter commented Jan 1, 2020

Uh oh!

madoar commented Jan 1, 2020

Uh oh!

Zemogiter commented Jan 4, 2020

Uh oh!

plata commented Jan 13, 2020

Uh oh!

Zemogiter commented Jan 14, 2020

Uh oh!

Uh oh!

Uh oh!

plata Apr 6, 2020

Choose a reason for hiding this comment

Uh oh!

Zemogiter commented May 12, 2020

Uh oh!

plata commented May 14, 2020

Uh oh!

Zemogiter commented May 14, 2020

Uh oh!

plata commented May 14, 2020

Uh oh!

Zemogiter commented May 14, 2020

Uh oh!

Zemogiter commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plata commented Jun 22, 2020

Uh oh!

Zemogiter commented Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

plata commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zemogiter commented Sep 8, 2019 •

edited

Loading

Zemogiter commented Nov 26, 2019 •

edited

Loading

Zemogiter commented Jun 22, 2020 •

edited

Loading

Zemogiter commented Jun 24, 2020 •

edited

Loading