Skip to content

chore(deps): update golang docker tag to v1.26.1 - autoclosed#897

Closed
renovate[bot] wants to merge 1 commit intomainfrom
renovate/golang-1.x
Closed

chore(deps): update golang docker tag to v1.26.1 - autoclosed#897
renovate[bot] wants to merge 1 commit intomainfrom
renovate/golang-1.x

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Feb 11, 2026

This PR contains the following updates:

Package Update Change
golang minor 1.25.81.26.1

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the help wanted Extra attention is needed label Feb 11, 2026
@ti-chi-bot ti-chi-bot bot added the size/L label Feb 11, 2026
@renovate renovate bot force-pushed the renovate/golang-1.x branch from 1527918 to dbda9a2 Compare February 12, 2026 12:06
@renovate renovate bot changed the title chore(deps): update golang docker tag to v1.26.0 chore(deps): update golang docker tag to v1.26.1 Mar 6, 2026
@renovate renovate bot force-pushed the renovate/golang-1.x branch from dbda9a2 to 906cade Compare March 6, 2026 02:49
@renovate renovate bot force-pushed the renovate/golang-1.x branch 2 times, most recently from 8c27bc2 to a22c78e Compare March 24, 2026 11:50
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 24, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dillon-zheng for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@renovate renovate bot force-pushed the renovate/golang-1.x branch from a22c78e to 88694bd Compare March 30, 2026 10:22
@ti-chi-bot ti-chi-bot bot added size/M and removed size/L labels Mar 30, 2026
@wuhuizuo
Copy link
Copy Markdown
Contributor

wuhuizuo commented Apr 2, 2026

Review result from delivery triage:

  • This PR is a Renovate-generated minor bump (golang 1.25.8 -> 1.26.1).
  • The current repository policy requested by the maintainer is to allow Renovate to auto-create patch-only update PRs, not minor bumps.
  • The root cause is in .github/renovate.json: the current golang/go rule uses separateMinorPatch: true, which separates minor and patch PRs but does not disable minor PR creation.

I am treating this PR as blocked by repository policy/config, not by code quality. A follow-up config change is being arranged to restrict Renovate to patch-only PRs for this dependency class. Until that config lands, I do not recommend approving this PR.

@wuhuizuo
Copy link
Copy Markdown
Contributor

wuhuizuo commented Apr 2, 2026

Follow-up status: the repository-policy fix is now under review in PingCAP-QE/artifacts#945.

Current handling decision:

  • #897 should not be approved, because it is exactly the type of Renovate-generated Go minor bump that the repository policy intends to stop auto-creating.
  • Once #945 merges, this PR should be closed as superseded by the Renovate policy change rather than merged as-is.

ti-chi-bot bot pushed a commit that referenced this pull request Apr 2, 2026
## Summary
- disable Renovate minor updates for Docker-based `golang` / `go`
dependencies
- keep patch updates enabled for the same dependency scope
- preserve the existing separation behavior for Go update PRs

## Why
`#897` shows that the current config still allows
minor Go toolchain bumps like `1.25.8 -> 1.26.1`. Repository policy is
to let Renovate auto-create patch-only PRs for this dependency class.

## Validation
- `jq . .github/renovate.json >/dev/null`
- `git diff --check`
- attempted `npx --yes --package renovate renovate-config-validator
.github/renovate.json`, but the repo already has pre-existing validator
errors on `customManagers[*].managerFilePatterns`, unrelated to this
change

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@renovate renovate bot changed the title chore(deps): update golang docker tag to v1.26.1 chore(deps): update golang docker tag to v1.26.1 - autoclosed Apr 2, 2026
@renovate renovate bot closed this Apr 2, 2026
@renovate renovate bot deleted the renovate/golang-1.x branch April 2, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant