Add brilliant-diamond-shining-pearl and scarlet-violet sprites

[misternic]

I know this is quite a large PR - hopefully you'll find some time to review it.

I've added all sprites from Brilliant Diamond & Shining Pearl as well as Scarlet & Violet.

I hope everything is correct; I double-checked all of it and even wrote a small report script in ./scripts that you can run. It calls the (local) API for every image in a folder and verifies that the returned image matches the file, ensuring there are no leftovers or missing assets. It also saves a lot of time. I’ve attached a generated report in this PR, but feel free to generate it on your end if you prefer. If you don't want the script and prefer to keep the folder clean, no problem at all.

report.html

Sources:

• https://www.spriters-resource.com/nintendo_switch/pokemonscarletviolet/asset/187087/
• https://www.spriters-resource.com/nintendo_switch/pokemonbrilliantdiamondshiningpearl/asset/164994/

It was quite a lot of work - especially starting from the Kalos generation, since the images use internal IDs instead of National Dex numbers. :D

I believe this PR might make the following one redundant, as it also attempted to add these sprites: #131

Here is the link to the PR in the main repository where the data model was updated to support the new sprites: PokeAPI/pokeapi#1352

If there's anything I can improve or anything that would make the review easier, just let me know. <3

[Naramsim]

I'll try to find some time to review it. Thanks!

[Naramsim]

This PR here @phalt . Once we merge it the other PR will expose the newly added sprites.

[Naramsim]

I think I can start looking at it next week

[Naramsim]

Hi! THanks for the great job! I reviewed it and it look good! Thanks! I also noted that you ran some image modifications with a Python script, could you explain a bit the resoning behind these? Also providing an example? (before and after)

In the meantime I'll merge the PR and thank you again!