Preserve partnership loss support in donor imputation#181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nonnegative_vars, and keep signed zero-inflated variables in the ZI-QRF zero gate.Why
Raw PUF has partnership/S-corp loss support, but the Gate-2 candidate H5 had zero negative
partnership_s_corp_incomerows. eCPS has negative rows and nonzero partnership/S-corp loss targets.The cause is that Microplex metadata marked partnership/S-corp income as
ZERO_INFLATED_POSITIVE, which put it innonnegative_vars; both donor imputer backends then clamp negative predictions withnp.maximum(..., 0).Validation
uv run --python 3.13 --extra dev pytest tests/test_variables.py tests/pipelines/test_us.py -k 'partnership_income_semantics or signed_zero_inflated_donor_vars or zi_qrf_backend'uv run --python 3.13 --extra dev ruff check src/microplex_us/variables.py src/microplex_us/pipelines/us.py tests/test_variables.py tests/pipelines/test_us.pyuv run --python 3.13 --extra dev ruff format --check src/microplex_us/variables.py src/microplex_us/pipelines/us.py tests/test_variables.py tests/pipelines/test_us.pyNotes
This does not touch the active rent/childcare PR lane. It removes a support-family mismatch; it does not add any target bucket cap or record-level adjustment.