Remove manual support sign controls from donor imputation#182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SUPPORT_SENSITIVEfamilyDonorMatchStrategy.ZERO_INFLATED_POSITIVEand let rank matching auto-detect positive zero-inflated donor supportRegimeAwareDonorImputernonnegative/sign/rare-class knobs and stop clamping support-sensitive predictions in Microplex-US27d23090) soZeroInflatedImputeruses purely observed-support regime detectionNotes
zi_qrfbackend still has its ownzero_inflated_vars/nonnegative_varsinternals; the productionregime_awarepath no longer accepts or passes manual sign/clamp controls.Tests
uv run --python 3.13 --extra dev ruff check src/microplex_us/variables.py src/microplex_us/pipelines/us.py src/microplex_us/pipelines/donor_imputers.py tests/test_variables.py tests/pipelines/test_us.py tests/pipelines/test_zi_qrf_backend.py tests/pipelines/test_regime_aware_donor_imputer.py tests/data_sources/test_scf_net_worth_components.pyuv run --python 3.13 --extra dev ruff format --check src/microplex_us/variables.py src/microplex_us/pipelines/us.py src/microplex_us/pipelines/donor_imputers.py tests/test_variables.py tests/pipelines/test_us.py tests/pipelines/test_zi_qrf_backend.py tests/pipelines/test_regime_aware_donor_imputer.py tests/data_sources/test_scf_net_worth_components.pyuv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/test_variables.py tests/pipelines/test_regime_aware_donor_imputer.py tests/pipelines/test_zi_qrf_backend.py tests/data_sources/test_scf_net_worth_components.py -quv run --python 3.13 --extra dev --extra policyengine python -m pytest tests/pipelines/test_us.py -k "donor_imputer or support_sensitive or zero_inflated or signed_zero or clamp" -qgit diff --check