Use ACS 2024 donor without changing CPS scaffold#184
Merged
Conversation
MaxGhenis
added a commit
that referenced
this pull request
Jun 3, 2026
… 2024
Toward making the source year a single key rather than a value smeared across
the provider/checkpoint/CLI/scripts/names:
- Profiles are addressed by (dataset, model_year): DatasetProfile.key and .name
(mp_ecps_2024), plus resolve_profile(dataset, year).
- version_id(variant, commit, build_date) derives the canonical build name from
the profile, so the asec{cps}-calendar{model} years in the name cannot drift
from the data (e.g. mp-ecps-shaped-asec2025-calendar2024-...). Names become an
output of the profile, never hand-typed.
- source_years() exposes the per-source years from one place, so callers thread
a profile instead of five loose year args.
- Correct MP_2024.acs to the native 2024 release (codex #184 default + the
ACS-2024 donor H5 fallback). Drops the earlier 2022 gap that wrongly anchored
on the stale manifest/scripts. ACS is excluded from the manifest-tie because
MP loads a local acs_2024.h5 beyond the module's ACS_2022 baseline.
Next (same PR or follow-up): thread `--profile` / source_years() through the CLI
and build scripts, derive the artifact version_id from the profile, and retire
the per-year args and `--*-year` flags.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acs_2024.h5can load even though the current PE-US-data Python module only exposesACS_2022Validation
uv run --python 3.13 --extra dev --extra policyengine pytest tests/test_donor_survey_source_providers.py -k acs_source_provideruv run --python 3.13 --extra dev --extra policyengine pytest tests/pipelines/test_pe_us_data_rebuild.py -k source_providersuv run --python 3.13 --extra dev --extra policyengine pytest tests/pipelines/test_us.py -k select_scaffold_prefers_cps_when_puf_support_clone_enableduv run --python 3.13 --extra dev --extra policyengine ruff check ...uv run --python 3.13 --extra dev --extra policyengine ruff format --check ...ACSSourceProvider(year=2024, policyengine_us_data_repo=...)