Skip to content

Fix CBO income source PE-native loss units#192

Merged
MaxGhenis merged 1 commit into
mainfrom
codex/fix-cbo-income-source-loss-units-20260602
Jun 3, 2026
Merged

Fix CBO income source PE-native loss units#192
MaxGhenis merged 1 commit into
mainfrom
codex/fix-cbo-income-source-loss-units-20260602

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • classify national CBO income-by-source targets as dollar targets before generic filer/count handling
  • add a regression test for the CBO self-employment and interest/non-qualified dividend targets that drove the Fix rent and childcare export inputs #190 APG tradeoff
  • preserve IRS count targets as return-count targets

Why

The #190 release-candidate APG comparison won headline robust national loss but regressed important IRS/investment-income surfaces. The top improvement/regression diagnostics showed CBO income_by_source/.../filers targets with dollar-scale targets (for example self-employment income and taxable-interest plus non-qualified dividends) were being bucketed as national:returns because the path ended with filers. That misbucketing distorts the robust loss objective and the release gate.

Tests

  • uv run --python 3.13 --project /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602 --extra dev python -m pytest /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/tests/pipelines/test_pe_native_loss.py
  • uv run --python 3.13 --project /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602 ruff check /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/src/microplex_us/pipelines/pe_native_loss.py /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/tests/pipelines/test_pe_native_loss.py

@MaxGhenis MaxGhenis merged commit f987e57 into main Jun 3, 2026
5 checks passed
@MaxGhenis MaxGhenis deleted the codex/fix-cbo-income-source-loss-units-20260602 branch June 3, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant