Fix CBO income source PE-native loss units#192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The #190 release-candidate APG comparison won headline robust national loss but regressed important IRS/investment-income surfaces. The top improvement/regression diagnostics showed CBO
income_by_source/.../filerstargets with dollar-scale targets (for example self-employment income and taxable-interest plus non-qualified dividends) were being bucketed asnational:returnsbecause the path ended withfilers. That misbucketing distorts the robust loss objective and the release gate.Tests
uv run --python 3.13 --project /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602 --extra dev python -m pytest /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/tests/pipelines/test_pe_native_loss.pyuv run --python 3.13 --project /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602 ruff check /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/src/microplex_us/pipelines/pe_native_loss.py /Users/maxghenis/.codex-worktrees/microplex-us-fix-cbo-income-unit-20260602/tests/pipelines/test_pe_native_loss.py