Skip to content

feat: Add adds/subtracts JSON columns to Variable model#103

Open
anth-volk wants to merge 2 commits intomainfrom
feat/add-adds-subtracts
Open

feat: Add adds/subtracts JSON columns to Variable model#103
anth-volk wants to merge 2 commits intomainfrom
feat/add-adds-subtracts

Conversation

@anth-volk
Copy link
Contributor

@anth-volk anth-volk commented Mar 6, 2026

Fixes #102

Summary

  • Adds adds and subtracts JSON columns to the VariableBase SQLModel
  • Includes autogenerated Alembic migration (0cbd97809414)
  • Updates seed script to populate adds/subtracts during bulk insert
  • Adds 5 unit tests for Variable model with adds/subtracts fields

Test plan

  • test_variable_with_adds — Variable with adds list, subtracts defaults to None
  • test_variable_with_subtracts — Variable with subtracts list, adds defaults to None
  • test_variable_with_adds_and_subtracts — Both fields populated
  • test_variable_with_null_adds_and_subtracts — Both default to None when omitted
  • test_variable_with_empty_adds — Empty list edge case

🤖 Generated with Claude Code

anth-volk and others added 2 commits March 6, 2026 20:07
Add JSON columns for variable aggregation metadata so the frontend can
render variable breakdown trees. Includes Alembic migration, seed script
update, and unit tests.

Closes #102

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@anth-volk anth-volk marked this pull request as ready for review March 6, 2026 20:04
@anth-volk anth-volk requested a review from SakshiKekre March 6, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add adds/subtracts JSON columns to Variable model

1 participant