feat: Add filter_strategy column and strategy reconstruction#105
Open
feat: Add filter_strategy column and strategy reconstruction#105
Conversation
…istricts - Alembic migration adding filter_strategy to regions and simulations tables - Strategy reconstruction utility to rebuild ScopingStrategy objects from DB columns - Updated analysis endpoints to extract and pass filter_strategy - Updated seed script to derive filter_strategy from policyengine.py regions - Comprehensive unit tests for strategy reconstruction and filter_strategy integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move imports inside reconstruct_strategy() function body so the module can be loaded without the unpublished scoping_strategy module. Tests use mock strategy classes injected via monkeypatch when the real module is unavailable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #104
Summary
filter_strategycolumn toregionsandsimulationstables (with data backfill)utils/strategy_reconstruction.py) to rebuildScopingStrategyobjects from DB columns at runtimefilter_strategyfrom regions and pass through simulation creationfilter_strategyfrompolicyengine.pyregion objectsTest plan
pytest tests/test_strategy_reconstruction.py— all 21 tests passpytest tests/test_analysis.py— all 43 tests pass (15 new)🤖 Generated with Claude Code