fix: Populate possible_values for enum variables during seeding#90
Closed
SakshiKekre wants to merge 1 commit intomainfrom
Closed
fix: Populate possible_values for enum variables during seeding#90SakshiKekre wants to merge 1 commit intomainfrom
SakshiKekre wants to merge 1 commit intomainfrom
Conversation
SakshiKekre
force-pushed
the
fix/enum-possible-values
branch
from
1530a88 to
b144a99
Compare
Previously, all variables were seeded with possible_values = NULL, even for enum-type variables like state_code and filing_status. Changes: - seed.py: Extract possible_values from policyengine package and store as JSON - variable.py: Fix type annotation from `str | None` to `list[str] | None` This enables API consumers to know valid values for constrained variables (e.g., state dropdowns, filing status options). Affects 89 variables (62 US + 27 UK) that have enumerated values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
SakshiKekre
force-pushed
the
fix/enum-possible-values
branch
from
b144a99 to
b81223c
Compare
Contributor
Author
|
Superseded by #91 which targets app-v2-migration branch instead of main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
possible_values = NULL, even for enum-type variables likestate_codeandfiling_statuspossible_valuesfrom thepolicyenginepackage and stores them as JSONChanges
scripts/seed.py: Usevar.possible_valuesinstead of hardcodingNoneImpact
possible_valuespopulatedstate_code,filing_status,tenure_type,council_tax_bandTest plan
policyenginepackage providespossible_valuesas listpossible_values🤖 Generated with Claude Code