fix: Update computation module tests for country_id parameter#92
Merged
anth-volk merged 1 commit intoapp-v2-migrationfrom Mar 3, 2026
Merged
fix: Update computation module tests for country_id parameter#92anth-volk merged 1 commit intoapp-v2-migrationfrom
anth-volk merged 1 commit intoapp-v2-migrationfrom
Conversation
The computation module functions now include a 7th parameter for country_id (passed as kwarg by run_modules). Some functions accept it explicitly while others use **_kwargs. Updated tests to: - Expect 7 parameters instead of 6 - Accept either 'country_id' or '_kwargs' as the 7th param name - Add **kwargs to tracker functions in mock tests - Include country_id='' in mock assertion expectations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
anth-volk
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_computation_modules.pyto handle the newcountry_idparameter added to computation module functionscountry_id(passed as kwarg byrun_modules)country_id: str = ""), others use**_kwargsChanges
country_idor_kwargsas the 7th param name**kwargsto tracker functions in mock testscountry_id=''in mock assertion expectationsBackground
Direct commits to
app-v2-migrationafter PR #89 addedcountry_idto module functions without updating the corresponding tests. This broke CI for any new PRs against this branch.🤖 Generated with Claude Code