Default metadata endpoints to latest model version and add version filtering#99
Draft
Default metadata endpoints to latest model version and add version filtering#99
Conversation
…_model_name consistently All metadata endpoints now default to the latest model version when tax_benefit_model_name is provided, and accept an optional tax_benefit_model_version_id for pinning to a specific older version. The by-name and children endpoints now accept tax_benefit_model_name instead of country_id for consistency with the other metadata endpoints. Closes #98 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Move all inline model/version/parameter/variable factories into test_fixtures/fixtures_version_filter.py and rewrite test files to import from there. Add new test_parameter_values.py covering CRUD, filtering, pagination, and version filtering for parameter values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Converting to draft; this doesn't yet fully migrate, causing us to create three different ways of querying for tax-benefit model version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_model_version_id()service helper that resolvestax_benefit_model_nameto the latest version and validates explicittax_benefit_model_version_id/parameters/,/variables/,/parameter-values/,/parameters/by-name,/parameters/children,/variables/by-name) now default to the latest model version whentax_benefit_model_nameis providedtax_benefit_model_version_idquery/body param to all endpoints for pinning to a specific older versioncountry_idwithtax_benefit_model_namein/parameters/by-name,/parameters/children,/variables/by-namefor consistencyTest plan
test_fixtures/fixtures_version_filter.pyCloses #98
🤖 Generated with Claude Code