Build architecture-specific macOS wheels#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
Summary
wheel tagsWHEELmetadata, and bundled Rust executable architecture agree before uploadTesting
PYTHONPYCACHEPREFIX=/private/tmp/pycache-uk-rust PYTHONPATH=interfaces/python PYTEST_ADDOPTS='-p no:cacheprovider' python -m pytest interfaces/python/tests/test_validate_wheel_artifact.py -qPYTHONPYCACHEPREFIX=/private/tmp/pycache-uk-rust PYTHONPATH=interfaces/python PYTEST_ADDOPTS='-p no:cacheprovider' python -m pytest interfaces/python/tests -qpython -c "import yaml; yaml.safe_load(open('.github/workflows/publish-pypi.yml'))"git diff --checkNotes
This adds release-time artifact validation but does not add a full PR wheel-build matrix. The existing PR workflow will run the validator unit tests through the Python wrapper test suite. A follow-up should decide whether to build and install smoke-test wheels on PRs, and whether Linux manylinux tags should be verified with
auditwheelor retagged to match the build containers.