Conversation
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
only rules in this repo
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
great to see this passing checks!
| definition_period = YEAR | ||
| unit = GBP | ||
| documentation = "Total VAT charged on firm's sales (output VAT)" | ||
|
|
There was a problem hiding this comment.
| defined_for = "firm_vat_registered" | |
| quantity_type = FLOW | ||
|
|
||
|
|
||
| class annual_input_k(Variable): |
There was a problem hiding this comment.
make all numbers pounds not thousands
| description = "Business firm variables from firm dataset." | ||
|
|
||
|
|
||
| class firm_id(Variable): |
There was a problem hiding this comment.
make each variable its own file
There was a problem hiding this comment.
don't think we need this or business_group - we're only targeting at this level not simulating at it
| turnover = firm("annual_turnover_k", period) * 1000 | ||
| threshold = parameters(period).gov.hmrc.vat.registration_threshold | ||
|
|
||
| return turnover > threshold |
There was a problem hiding this comment.
they can choose to register if under right? can be beneficial?
if so we may need another variable here that's from the calibrated dataset like registers_for_vat_if_not_required
| output_vat = firm("firm_vat_on_sales", period) | ||
| input_vat = firm("firm_vat_on_purchases", period) | ||
|
|
||
| return output_vat - input_vat |
|
Closing per review feedback — firm analysis files belong in a separate repo, not in the rules repo. |
2 participants
Fixes #1333