Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7202 +/- ##
===========================================
+ Coverage 97.82% 100.00% +2.17%
===========================================
Files 3 3
Lines 92 44 -48
Branches 2 1 -1
===========================================
- Hits 90 44 -46
+ Misses 1 0 -1
+ Partials 1 0 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PR Review - Washington TANF Backdating🔴 Critical Issues (Must Fix Before Merge)None identified. All historical values verified against WSR filings. 🟡 Should Address1. Missing 2022-01 Period TestsSeveral test files lack coverage for the 2022-01 period (uses July 2021 values):
2. Missing 2025-01 Period Tests
3. Missing Reference for 2024 Payment StandardsFile:
4. Missing Reference for Historical $1,000 Resource LimitFile:
5. Minor Date Discrepancy for 2016 Values
🟢 Suggestions
✅ What's Verified Correct
Key Policy Timeline Verified:
Validation Summary
Code Changes Verified
Test Coverage: 83 Tests Passing
Historical Value VerificationPayment Standard Size 1:
Income Limit Relationship Verified:
Next StepsTo auto-fix issues: Or address manually:
🤖 Generated with Claude Code - Complete Review Plugin |
PavelMakarchuk
left a comment
There was a problem hiding this comment.
Not sure if I am right, but can we add an integration test or two for 2018 for all backdating PRs?
|
|
||
| values: | ||
| 2024-01-01: 500 | ||
| 2024-08-01: 500 |
There was a problem hiding this comment.
It will not work with this parameter being backdated right?
There was a problem hiding this comment.
This $500 disregard is a new feature start effect in 2024-08. So if 2024-07, no 500 disregard, to test it output, compare test cases of 2024-01 and 2025-01
I have test cases in wa_tanf_countable_earned_income.yaml |
WSR 16-01-093 effective date is January 15, 2016, not February 1. Changed 2016-02-01 to 2016-01-15 in payment_standard/amount.yaml and income/limit.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The amount parameter only had a value starting 2024-08-01, causing a ParameterNotFoundError when microsimulation ran for 2024-01-01. Added 1998-09-01: 0 so the parameter is always defined. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…exists Replaced numpy where(p.in_effect, p.amount, 0) with a Python if on the scalar p.in_effect parameter. This avoids resolving p.amount before 2024-08-01, fixing the microsim ParameterNotFoundError without needing a dummy 1998-09-01: 0 value in amount.yaml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary
Fixes #7199
Adds historical parameter values to Washington TANF, extending data back to 2016 based on Washington State Register (WSR) filings. Also corrects effective dates, removes an erroneous maximum grant cap, and adds a boolean toggle for the $500 flat earned income disregard introduced by HB 1447.
Regulatory Authority
Historical WSR Filings
Income Eligibility Test
Gross earned income must be at or below the published income limit for the assistance unit size per WAC 388-478-0035. These limits already incorporate the $500 family earnings deduction (after Aug 2024).
Income Deductions & Exemptions
Order of operations (per WAC 388-450-0170):
Income Standards
Payment Standards (WAC 388-478-0020)
Income Limits (WAC 388-478-0035)
Resource Limits (WAC 388-470-0005)
Benefit Calculation
Per WAC 388-450-0162:
Where:
payment_standard= amount from WAC 388-478-0020 for the assistance unit size (capped at size 10)countable_income= countable earned income (after disregards) + gross unearned incomeMaximum Grant Cap Removal
This PR removes a previously implemented $1,338 maximum grant cap (
payment_standard/maximum_amount.yaml). This cap does not exist in current regulation:Changes
Parameters Updated
payment_standard/amount.yamlincome/limit.yamlresource_limit.yamlmaximum_family_size.yamlearned_income_disregard/rate.yamlpercentage_disregarded.yaml)earned_income_disregard/amount.yamlearned_income_disregard/in_effect.yamlParameters Deleted
payment_standard/maximum_amount.yaml— erroneous $1,338 cap (see rationale above)Variables Updated
wa_tanf.py— removed maximum_amount cap; benefit = max(payment_standard − countable_income, 0)wa_tanf_countable_earned_income.py— usesin_effectboolean to gate the $500 flat disregard by periodwa_tanf_eligible.py— refactored immigration check to useadd()instead ofspm_unit.any()Audit Verification
All 96 parameter values verified against regulatory sources (0 mismatches):
Test Plan
🤖 Generated with Claude Code