You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Helps verify the contents of the published manifest for packages/agent and what would be included in the tarball.
Ran code and verified through T-Rex
Comments Outside Diff (2)
apps/code/SCHEMA.md
Preserve analytics catalog
Deleting this file drops the analytics event catalog and the “Adding a new event” checklist, but the new docs only keep the naming rules. When someone adds a tracked event, they no longer have the canonical place that explains which catalog row to update and what each existing event means, so the analytics docs can drift from ANALYTICS_EVENTS even though this PR is meant to split the guide into reference docs.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/SCHEMA.md
Line: 86
Comment:
**Preserve analytics catalog**
Deleting this file drops the analytics event catalog and the “Adding a new event” checklist, but the new docs only keep the naming rules. When someone adds a tracked event, they no longer have the canonical place that explains which catalog row to update and what each existing event means, so the analytics docs can drift from `ANALYTICS_EVENTS` even though this PR is meant to split the guide into reference docs.
How can I resolve this? If you propose a fix, please make it concise.
packages/agent/package.json still whitelists CLAUDE.md, but no packages/agent/CLAUDE.md exists. The package dry-run succeeds silently and publishes a tarball without that file, so consumers of @posthog/agent will not receive the agent context file that the manifest still declares.
Keeps the command output available without making the summary code-heavy.
Ran code and verified through T-Rex
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 1
apps/code/SCHEMA.md:86
**Preserve analytics catalog**
Deleting this file drops the analytics event catalog and the “Adding a new event” checklist, but the new docs only keep the naming rules. When someone adds a tracked event, they no longer have the canonical place that explains which catalog row to update and what each existing event means, so the analytics docs can drift from `ANALYTICS_EVENTS` even though this PR is meant to split the guide into reference docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StamphogThis will request an autostamp by stamphog on small changes
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split dev guide into AGENTS.md and reference docs
This is good to merge before refactor stuff, should help a little bit in the interim