Skip to content

fix(inbox): break signal summary sections onto separate lines#2317

Open
MattPua wants to merge 2 commits into
mainfrom
cursor/signal-summary-section-line-breaks
Open

fix(inbox): break signal summary sections onto separate lines#2317
MattPua wants to merge 2 commits into
mainfrom
cursor/signal-summary-section-line-breaks

Conversation

@MattPua
Copy link
Copy Markdown
Member

@MattPua MattPua commented May 22, 2026

Problem

Signals had sections in the same line, which means it can be difficult to skim through quickly.

CleanShot 2026-05-22 at 17 38 32@2x

Changes

Insert line breaks around What's happening, Root cause, and How to resolve headers so report summaries are easier to scan.

CleanShot 2026-05-22 at 17 38 44@2x

How did you test this?

Locally.

Publish to changelog?

Insert line breaks around What's happening, Root cause, and How to resolve headers so report summaries are easier to scan.

Co-authored-by: Cursor <cursoragent@cursor.com>
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
apps/code/src/renderer/features/inbox/components/utils/SignalReportSummaryMarkdown.tsx:27-32
The `listMarkdown` computation splits `raw` on the first newline, but after formatting, `raw` now begins with `**What's happening:**`, so `listMarkdown` becomes just `"**What's happening:**"`. The `list` variant then renders only the bold header (e.g. "What's happening:") with no actual summary content — a regression from the previous behaviour where the full inline text was visible. Using the pre-formatted content for the list split preserves the original single-line text for the list preview.

```suggestion
  const rawContent = content?.trim() ? content : fallback;
  const raw = formatSignalReportSummaryMarkdown(rawContent);

  /** List rows: only the first line (before first newline); CSS still caps visual lines. */
  const listMarkdown = rawContent.split(/\r?\n/)[0] ?? "";
```

### Issue 2 of 2
apps/code/src/renderer/features/inbox/utils/formatSignalReportSummaryMarkdown.test.ts:4-33
All four cases share the same `(input, expected)` shape and should be collapsed into a single `it.each` table, per the team's preference for parameterised tests.

Reviews (1): Last reviewed commit: "fix(inbox): break signal summary section..." | Re-trigger Greptile

Use unformatted content for inbox list rows so line breaks added for detail view do not truncate previews to section headers only.

Co-authored-by: Cursor <cursoragent@cursor.com>
@MattPua MattPua requested review from Twixes and sortafreel May 25, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant