fix(sidebar): show PR state on cloud task icons, stop constant pulse#2346
Open
richardsolomou wants to merge 1 commit into
Open
fix(sidebar): show PR state on cloud task icons, stop constant pulse#2346richardsolomou wants to merge 1 commit into
richardsolomou wants to merge 1 commit into
Conversation
`in_progress` covers the entire time a cloud run is alive on the backend, including when the agent is idle waiting for the next user message. The `ph-pulse` animation on that state made every active cloud task look like it was constantly doing something, and the local "agent is generating right now" signal (`isPromptPending` → `DotsCircleSpinner`) was already handling the real "active" affordance. Two changes: - Pulse only on `queued` (genuinely transient, usually a few seconds). `in_progress` renders as a steady filled accent cloud/Slack icon. - Drop the cloud short-circuit in `TaskIcon` so cloud tasks share the same precedence as local: needsPermission → terminalCloud → isGenerating → isSuspended → isUnread → PR/diff → isPinned → `CloudStatusIcon` (non-terminal) → originProductMeta → `ChatCircle`. Cloud tasks with an open PR now show the PR icon, with a diff show the branch icon, suspended show the pause icon, etc. — same as local tasks. Generated-By: PostHog Code Task-Id: b95e757c-ba51-444c-978c-27c02e740d85
Contributor
|
Reviews (1): Last reviewed commit: "fix(sidebar): stop pulsing cloud icon fo..." | Re-trigger Greptile |
richardsolomou
changed the title
richardsolomou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ph-pulseanimation ran for the wholein_progresswindow, so every active cloud task looked permanently busy. And theisCloudTaskshort-circuit inTaskIconhid PR, diff, suspended, unread, and pinned state on non-terminal cloud tasks, so a cloud task with an open PR did not get the green PR icon a local task would.Changes
queued.in_progressrenders as a steady filled accent icon.isCloudTaskreturn so PR/diff/suspended/unread/pinned state takes precedence over the cloud icon.cloudPrUrlnow show the same green/purpleGitPullRequest/GitMergeicon as local tasks (hasDiffamber branch still requires a local worktree).How did you test this?
pnpm --filter code typecheckandpnpm lintpass. I did not run the desktop app, so the new icons are not visually verified.Publish to changelog?
no