-
Notifications
You must be signed in to change notification settings - Fork 31
feat(mobile): attach app version to all custom events #2404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Gilbert09
merged 1 commit into
main
from
posthog-code/mobile-app-version-super-property
May 28, 2026
+151
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| import { beforeEach, describe, expect, it, vi } from "vitest"; | ||
|
|
||
| const expoApplication = { | ||
| nativeApplicationVersion: null as string | null, | ||
| }; | ||
|
|
||
| const expoConstants = { | ||
| expoConfig: null as { version?: string } | null, | ||
| }; | ||
|
|
||
| vi.mock("posthog-react-native", () => ({ | ||
| usePostHog: () => null, | ||
| })); | ||
|
|
||
| vi.mock("expo-router", () => ({ | ||
| usePathname: () => "/", | ||
| useSegments: () => [] as string[], | ||
| })); | ||
|
|
||
| vi.mock("expo-application", () => ({ | ||
| get nativeApplicationVersion() { | ||
| return expoApplication.nativeApplicationVersion; | ||
| }, | ||
| })); | ||
|
|
||
| vi.mock("expo-constants", () => ({ | ||
| default: { | ||
| get expoConfig() { | ||
| return expoConstants.expoConfig; | ||
| }, | ||
| }, | ||
| })); | ||
|
|
||
| beforeEach(() => { | ||
| vi.clearAllMocks(); | ||
| expoApplication.nativeApplicationVersion = null; | ||
| expoConstants.expoConfig = { version: "0.0.0-test" }; | ||
| }); | ||
|
|
||
| describe("getAppVersion", () => { | ||
| it("prefers the native application version when present", async () => { | ||
| expoApplication.nativeApplicationVersion = "9.8.7"; | ||
| expoConstants.expoConfig = { version: "0.0.0-test" }; | ||
|
|
||
| const { getAppVersion } = await import("./posthog"); | ||
|
|
||
| expect(getAppVersion()).toBe("9.8.7"); | ||
| }); | ||
|
|
||
| it("falls back to the Expo config version when no native version is available", async () => { | ||
| expoApplication.nativeApplicationVersion = null; | ||
| expoConstants.expoConfig = { version: "1.2.3" }; | ||
|
|
||
| const { getAppVersion } = await import("./posthog"); | ||
|
|
||
| expect(getAppVersion()).toBe("1.2.3"); | ||
| }); | ||
|
|
||
| it("returns null when neither source has a version", async () => { | ||
| expoApplication.nativeApplicationVersion = null; | ||
| expoConstants.expoConfig = null; | ||
|
|
||
| const { getAppVersion } = await import("./posthog"); | ||
|
|
||
| expect(getAppVersion()).toBeNull(); | ||
| }); | ||
| }); | ||
|
|
||
| describe("registerAppVersion", () => { | ||
| it("registers app_version as a super property on the PostHog client", async () => { | ||
| const register = vi.fn(); | ||
| const { registerAppVersion } = await import("./posthog"); | ||
|
|
||
| registerAppVersion({ register }, "1.2.3"); | ||
|
|
||
| expect(register).toHaveBeenCalledTimes(1); | ||
| expect(register).toHaveBeenCalledWith({ app_version: "1.2.3" }); | ||
| }); | ||
|
|
||
| it("does nothing when the PostHog client is not yet available", async () => { | ||
| const { registerAppVersion } = await import("./posthog"); | ||
|
|
||
| expect(() => registerAppVersion(null, "1.2.3")).not.toThrow(); | ||
| }); | ||
|
|
||
| it("does nothing when no app version can be resolved", async () => { | ||
| const register = vi.fn(); | ||
| const { registerAppVersion } = await import("./posthog"); | ||
|
|
||
| registerAppVersion({ register }, null); | ||
|
|
||
| expect(register).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it("resolves the version from getAppVersion when none is provided", async () => { | ||
| expoApplication.nativeApplicationVersion = "4.5.6"; | ||
| const register = vi.fn(); | ||
| const { registerAppVersion } = await import("./posthog"); | ||
|
|
||
| registerAppVersion({ register }); | ||
|
|
||
| expect(register).toHaveBeenCalledWith({ app_version: "4.5.6" }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getAppVersionThe three
getAppVersioncases share an identical structure — setnativeApplicationVersion, setexpoConfig, callgetAppVersion, assert the result. The project convention is to consolidate these into a singleit.eachtable rather than repeating the scaffolding three times. The same pattern applies to the two "does nothing" cases inregisterAppVersion.Context Used: Do not attempt to comment on incorrect alphabetica... (source)
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!