Skip to content

ci: run smoke tests after build#2434

Merged
jonathanlab merged 4 commits into
mainfrom
ci/smoke-test-afer-build
May 29, 2026
Merged

ci: run smoke tests after build#2434
jonathanlab merged 4 commits into
mainfrom
ci/smoke-test-afer-build

Conversation

@jonathanlab
Copy link
Copy Markdown
Contributor

We were not running E2E tests on the release artifacts, making it possible to release a build that would not boot at all.

This is the same E2E test we run during the build step on a PR, but during release. See #2385 and #2433 for a scenario where CI passed, but the release would still not boot.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 29, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/code-release.yml:143-144
The `playwright install --with-deps chromium` step downloads a Chromium browser binary (~150 MB) that is never used. The smoke tests launch the packaged Electron app directly via `_electron.launch({ executablePath: appPath })`, so Playwright's own Chromium runtime is not involved. On macOS the `--with-deps` flag also does not install meaningful system packages (unlike Linux). This adds unnecessary time and bandwidth to every release run.

```suggestion
      - name: Install Playwright
        run: pnpm --filter code exec playwright install
```

Reviews (1): Last reviewed commit: "ci: run smoke tests after build" | Re-trigger Greptile

Comment thread .github/workflows/code-release.yml Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@jonathanlab jonathanlab enabled auto-merge (squash) May 29, 2026 13:27
@jonathanlab jonathanlab added the Create Release This will trigger a new release label May 29, 2026
@jonathanlab jonathanlab merged commit 61f39dd into main May 29, 2026
21 checks passed
@jonathanlab jonathanlab deleted the ci/smoke-test-afer-build branch May 29, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create Release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants