ci: run smoke tests after build#2434
Merged
Merged
Conversation
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
.github/workflows/code-release.yml:143-144
The `playwright install --with-deps chromium` step downloads a Chromium browser binary (~150 MB) that is never used. The smoke tests launch the packaged Electron app directly via `_electron.launch({ executablePath: appPath })`, so Playwright's own Chromium runtime is not involved. On macOS the `--with-deps` flag also does not install meaningful system packages (unlike Linux). This adds unnecessary time and bandwidth to every release run.
```suggestion
- name: Install Playwright
run: pnpm --filter code exec playwright install
```
Reviews (1): Last reviewed commit: "ci: run smoke tests after build" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
k11kirky
approved these changes
May 29, 2026
…to ci/smoke-test-afer-build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were not running E2E tests on the release artifacts, making it possible to release a build that would not boot at all.
This is the same E2E test we run during the build step on a PR, but during release. See #2385 and #2433 for a scenario where CI passed, but the release would still not boot.