Skip to content

chore: validate PR titles with conventional commits#629

Merged
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits
May 27, 2026
Merged

chore: validate PR titles with conventional commits#629
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits

Conversation

@dustinbyrne
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Our changelog automation uses merged PR titles to determine changelog candidates/entries. Enforcing Conventional Commit PR titles across SDK repos keeps titles structured and easier to classify consistently.

💚 How did you test it?

  • Parsed the new workflow YAML locally with PyYAML.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • No changeset/Sampo entry needed for this CI-only change.

@dustinbyrne dustinbyrne requested a review from a team as a code owner May 27, 2026 16:33
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/lint-pr.yml:6-8
**Missing `reopened` event type**

The `reopened` event type is absent from the trigger list. If a PR is closed and then reopened without any subsequent commits or title edits, the validation job will never fire — leaving a PR with a non-conforming title able to slip through unvalidated. Most semantic-PR workflows include `reopened` alongside `opened`, `edited`, and `synchronize`.

Reviews (1): Last reviewed commit: "chore: validate PR titles with conventio..." | Re-trigger Greptile

Comment thread .github/workflows/lint-pr.yml
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

posthog-python Compliance Report

Date: 2026-05-27 16:41:30 UTC
Duration: 176119ms

✅ All Tests Passed!

45/45 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 515ms
Format Validation.Event Has Uuid 1508ms
Format Validation.Event Has Lib Properties 1506ms
Format Validation.Distinct Id Is String 1507ms
Format Validation.Token Is Present 1507ms
Format Validation.Custom Properties Preserved 1507ms
Format Validation.Event Has Timestamp 1507ms
Retry Behavior.Retries On 503 9514ms
Retry Behavior.Does Not Retry On 400 3510ms
Retry Behavior.Does Not Retry On 401 3508ms
Retry Behavior.Respects Retry After Header 9514ms
Retry Behavior.Implements Backoff 23529ms
Retry Behavior.Retries On 500 7504ms
Retry Behavior.Retries On 502 7509ms
Retry Behavior.Retries On 504 7514ms
Retry Behavior.Max Retries Respected 23520ms
Deduplication.Generates Unique Uuids 1508ms
Deduplication.Preserves Uuid On Retry 7516ms
Deduplication.Preserves Uuid And Timestamp On Retry 14521ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 7509ms
Deduplication.No Duplicate Events In Batch 1507ms
Deduplication.Different Events Have Different Uuids 1506ms
Compression.Sends Gzip When Enabled 1507ms
Batch Format.Uses Proper Batch Structure 1507ms
Batch Format.Flush With No Events Sends Nothing 1005ms
Batch Format.Multiple Events Batched Together 1506ms
Error Handling.Does Not Retry On 403 3509ms
Error Handling.Does Not Retry On 413 3508ms
Error Handling.Retries On 408 7513ms

Feature_Flags Tests

16/16 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 1003ms
Request Payload.Flags Request Uses V2 Query Param 1007ms
Request Payload.Flags Request Hits Flags Path Not Decide 1006ms
Request Payload.Flags Request Omits Authorization Header 1007ms
Request Payload.Token In Flags Body Matches Init 1006ms
Request Payload.Groups Round Trip 1007ms
Request Payload.Groups Default To Empty Object 1006ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 1007ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 1006ms
Request Payload.Disable Geoip Omitted Defaults To False 1006ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 1007ms
Request Lifecycle.No Flags Request On Init Alone 503ms
Request Lifecycle.No Flags Request On Normal Capture 1511ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 1011ms
Request Lifecycle.Mock Response Value Is Returned To Caller 1002ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 1510ms

@dustinbyrne dustinbyrne enabled auto-merge (squash) May 27, 2026 16:51
@dustinbyrne dustinbyrne merged commit bf63368 into main May 27, 2026
27 checks passed
@dustinbyrne dustinbyrne deleted the chore/validate-pr-title-conventional-commits branch May 27, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants