Skip to content

chore: validate PR titles with conventional commits#155

Merged
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits
May 27, 2026
Merged

chore: validate PR titles with conventional commits#155
dustinbyrne merged 2 commits into
mainfrom
chore/validate-pr-title-conventional-commits

Conversation

@dustinbyrne
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Our changelog automation uses merged PR titles to determine changelog candidates/entries. Enforcing Conventional Commit PR titles across SDK repos keeps titles structured and easier to classify consistently.

💚 How did you test it?

  • Parsed the new workflow YAML locally with PyYAML.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • No changeset/Sampo entry needed for this CI-only change.

@dustinbyrne dustinbyrne requested a review from a team as a code owner May 27, 2026 16:33
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 27, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
.github/workflows/lint-pr.yml:5-8
The `reopened` event type is missing. Without it, reopening a previously closed PR (without editing it) skips title validation, so a PR with a non-conforming title could be merged after a reopen cycle without ever triggering the linter.

```suggestion
    types:
      - opened
      - edited
      - synchronize
      - reopened
```

Reviews (1): Last reviewed commit: "chore: validate PR titles with conventio..." | Re-trigger Greptile

Comment thread .github/workflows/lint-pr.yml
@dustinbyrne dustinbyrne enabled auto-merge (squash) May 27, 2026 16:51
@dustinbyrne dustinbyrne merged commit f70e4eb into main May 27, 2026
14 checks passed
@dustinbyrne dustinbyrne deleted the chore/validate-pr-title-conventional-commits branch May 27, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants