Skip to content

Cleanup main model: Clean all includes and make some components to be forward declared#1142

Merged
figueroa1395 merged 52 commits intomainfrom
feature/component-fwd-cleanup
Feb 16, 2026
Merged

Cleanup main model: Clean all includes and make some components to be forward declared#1142
figueroa1395 merged 52 commits intomainfrom
feature/component-fwd-cleanup

Conversation

@nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Sep 29, 2025 •
edited
Loading

Idea is to make components forward declared to reduce coupling.

This draft PR is created for gathering thoughts and requirements as of now.

Changes proposed in this PR include:

  • Forward declared all components
  • Removed unecessary exception and logging includes.

We shall maintain include discipline from now. Include order would be:

For include / source files

  • Important files (Main subjects). (Intention is to highlight for readability and not be strict)
  • Other required files
  • External dependencies
  • Standard library

For tests:

  • Helper includes of test
  • Important files to be tested (Main subjects). (Intention is to highlight for readability and not be strict)
  • Other required files
  • External dependencies
  • Testing dependencies
  • Standard library

In general, use <> for external. "" for internal. Note: PGM includes in test are treated as external, hence they go as <>.

@nitbharambe
change to forward declarations
34ba5b2 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe self-assigned this Sep 29, 2025
@nitbharambe nitbharambe added the improvement Improvement on internal implementation label Sep 29, 2025
@figueroa1395
Copy link
Member

figueroa1395 commented Oct 1, 2025

I like the cleanup. Now I wonder, should we move all_components.hpp to the component folder? Also seems intuitive to me to rename component.hpp to all_components_fwd.hpp, or somehow homogenize the two.

In addition, can we also include component_list in this "revolution"? Perhaps it now belongs in component.hpp and we try to keep all component related stuff in one location only.

@nitbharambe
change incldues
f889ae6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change incldues fix
9e8c714 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add component test includes
5cf953d 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add common test includes
be33aef 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add eigen ignore
ad81da1 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

nitbharambe and others added 6 commits December 11, 2025 12:47
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
473994d
@nitbharambe
remove TODO
5418455 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
a463032
@nitbharambe
add new test file include
b054e9f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove comments
424f032 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix assert missing
dffc4f4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review January 7, 2026 13:32
figueroa1395
figueroa1395 reviewed Jan 8, 2026
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional thing is that perhaps #1142 (comment) is still relevant. Also, maybe triggering Copilot for review might be useful since missing things for a human due to the nature of this PR is very easy.

Rest looks good, just minor questions.

nitbharambe and others added 2 commits January 12, 2026 09:26
@nitbharambe
rename to checkoptions
c3c6f95 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
924e928
mgovers
mgovers reviewed Jan 12, 2026
View reviewed changes
@nitbharambe
clean pt 2
4a5b00c 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as draft January 26, 2026 14:32
@nitbharambe
fix include search place
529d379 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add more includes
b32792a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add more includes 2
2b6f670 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add more includes 3
c59acaf 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
operator s includes
eee37dd 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
remove includes
21162c0 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add definition option
986e1b2 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
order tests
c654df3 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
clean c api
53342b4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
minor addition
829e229 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add reuse
950e953 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers reviewed Feb 6, 2026
View reviewed changes
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome progress

@nitbharambe
remaining
af44f45 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
missing final
94a4663 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
align code generation
43fa941 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add clang tidy and d settings
e3d3cc2 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
solve package test incldues
53f68e7 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
revert experiment of nolint
96e3e9e 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe marked this pull request as ready for review February 9, 2026 12:22
figueroa1395
figueroa1395 reviewed Feb 11, 2026
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just minor comments about clangd and the meta_data stuff handling. After that I think this can be merged.

@nitbharambe
add boost to ignore
b31ddc6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Merge branch 'main' into feature/component-fwd-cleanup
1ea6804 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
figueroa1395
figueroa1395 previously approved these changes Feb 12, 2026
View reviewed changes
@nitbharambe
merging formatting changes
c131192 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
mgovers
mgovers reviewed Feb 16, 2026
View reviewed changes
@nitbharambe @mgovers
Update .clangd
53b60b3 
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 16, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@figueroa1395 figueroa1395 added this pull request to the merge queue Feb 16, 2026
Merged via the queue into main with commit e48c31e Feb 16, 2026
31 checks passed
@figueroa1395 figueroa1395 deleted the feature/component-fwd-cleanup branch February 16, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo Jerry-Jinfeng-Guo left review comments

@mgovers mgovers mgovers left review comments

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@nitbharambe nitbharambe

Labels

improvement Improvement on internal implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nitbharambe @figueroa1395 @Jerry-Jinfeng-Guo @mgovers

Comments