fix(Chocolatey): 🐛 Add --yess to Install + improve code readability#174
Merged
Conversation
* Standardized parameter descriptions in the `Get-ChocoInstalledPackage`, `Get-ChocoLatestPackage`, and `Invoke-ChocoInstallPackage` functions. * Enhanced code readability by restructuring command arguments and conditions. * Added "lessmsi" to the cspell dictionary for improved spell checking.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Chocolatey dependency script to make installs non-interactive and refactors some command construction for readability, with a small spell-check dictionary update.
Changes:
- Adds
--yesto Chocolatey upgrade/install arguments. - Refactors Chocolatey command invocations into splatted hashtables.
- Adds
lessmsito the cspell dictionary.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
PSDepend/PSDependScripts/Chocolatey.ps1 |
Updates Chocolatey install/list command construction, documentation formatting, and install confirmation behavior. |
cspell.json |
Adds lessmsi as an accepted spelling. |
Comments suppressed due to low confidence (1)
PSDepend/PSDependScripts/Chocolatey.ps1:123
- Using
-PassThruas a hashtable value is not a valid switch value in a splat; this should be a Boolean (for example$true) so the script parses and passes the switch correctly.
PassThru = -PassThru
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 4 files 68 suites 2m 14s ⏱️ Results for commit 016e46d. ♻️ This comment has been updated with latest results. |
…ential * Updated `PassThru` to `$true` for proper command execution. * Ensured that the provided `$Credential` is used instead of prompting for it.
Regression guard: verifies the suppress-prompt flag survives future edits to Invoke-ChocoInstallPackage argument list.
…package versions * Updated verbose output to reflect the actual installed version and the latest version found in the repository. * Changed `PassThru` parameter to `$true` for consistency in command execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Most important change was to add
--yesto choco install.Get-ChocoInstalledPackage,Get-ChocoLatestPackage, andInvoke-ChocoInstallPackagefunctions.Why
If this isn't added, users may not expect to be responding to choco on install. We already prompt for installs and a 2nd prompt isn't needed.
Closes #119
Type of change
Checklist
Invoke-psake Analyzepasses locally with no new warningsInvoke-psake Testpasses locally on at least one platformCHANGELOG.mdupdated (required for any user-facing change)Additional notes