Open
Conversation
Agrees on expression types with the default typechecker on a wide range of files. Still has problems with implicit int to float conversions, but that should be easiliy fixable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new typechecker to vdiff. Currently the type information on expressions is correct most of the time, but there is at least one bug relating to "long long" types. More interestingly, for simplification reasons I changed the definition of
AnnTranslationUnit SemPhaseto not include theGlobalDeclsas an annotation anymore (it was never needed anyway). It seems like that this was the piece of cylic datatype (or computation?) that caused the crashes.So this means that this typechecker here is probably superfluous.