-
Notifications
You must be signed in to change notification settings - Fork 485
Add SandboxMixin to CliAgentEnv #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rasdani
wants to merge
22
commits into
main
Choose a base branch
from
daniel/sandbox-mixin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,015
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e830b56 to
a0e709d
Compare
a0e709d to
e46ccc6
Compare
e46ccc6 to
2c7a502
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extract sandbox lifecycle management into a reusable mixin for CliAgentEnv.
Can be used in
SandboxEnvtoo.Changes
Type of Change
Testing
uv run pytestlocally.Checklist
Additional Notes
Note
Medium Risk
Touches sandbox lifecycle and async concurrency/streaming paths (creation, teardown, retries, and cancellation), where subtle timing issues can cause leaks or hangs; changes are scoped to experimental envs but affect infrastructure behavior.
Overview
Refactors experimental sandboxed agent environments by introducing
SandboxMixin(with a pooledThreadedAsyncSandboxClient, retry/backoff, active sandbox tracking, and bulk teardown) and makingCliAgentEnvinherit it;CliAgentEnvnow centralizes sandbox creation/deletion, adds per-rollout timeout hooks, and adds extensive request/stream/LLM flow logging plus HTTP future timeouts to avoid hung intercept handlers.Improves reliability around interrupts:
MultiTurnEnv.rolloutnow explicitly runs cleanup onasyncio.CancelledError, andCliAgentEnvadds@vf.teardownhooks to bulk-delete leftover sandboxes and tear down the sandbox client threadpool.Enhances
HarborEnvwith per-task timeout/resource overrides fromtask.toml, optional capture of per-episode artifacts from/logs, and more robust verifier execution (background-job based with tenacity retries) while skipping tests on prior infra errors.Documentation updates clarify that
@vf.cleanupmethods should be idempotent and updateCliAgentEnvparameter docs accordingly.Written by Cursor Bugbot for commit 3e1ec44. This will update automatically on new commits. Configure here.