-
Notifications
You must be signed in to change notification settings - Fork 481
verifiers: fix tool call rendering from saved outputs #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
verifiers/utils/message_utils.py
Outdated
|
|
||
| def normalize_tool_call(tc: Any) -> dict[str, str]: | ||
| if isinstance(tc, str): | ||
| tc = json.loads(tc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unhandled JSON parse error in tool call normalization
Medium Severity
The new normalize_tool_call function calls json.loads(tc) when tc is a string, but this call is not wrapped in a try-except block. If a malformed JSON string is encountered (e.g., corrupted data, old format, or encoding issues), a json.JSONDecodeError will be raised and propagate up, potentially crashing the TUI display. This is inconsistent with the defensive handling of json.dumps(args) later in the same function, which is wrapped in a try-except.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
mikasenghaas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Since tools are json-serialized, they are no longer correctly displayed in the tui:
This PR fixes that problem:
Type of Change
Testing
uv run pytestlocally.Checklist
Note
Low Risk
Low risk refactor/bugfix limited to Rich formatting utilities and call sites; main risk is minor display regressions or unexpected tool-call string shapes causing JSON decode errors.
Overview
Fixes Rich/TUI rendering of prompts/completions when
tool_callsare stored as JSON strings by introducing a sharedformat_messages()helper that deserializes and pretty-prints tool calls.Removes duplicated message-formatting code in
eval_display.pyandlogging_utils.pyand switches both to the new shared formatter to keep prompt/completion display consistent.Written by Cursor Bugbot for commit c684082. This will update automatically on new commits. Configure here.