test : added unit tests for webhook signature verification#788
test : added unit tests for webhook signature verification#788tmdeveloper007 wants to merge 0 commit into
Conversation
|
@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
b60d00f to
a3930ae
Compare
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Tests must import from source — not reimplement the function locally.
The test file re-implements the function being tested inside the test itself. This defeats the purpose of testing — changes to the real implementation won't fail these tests.
Fix: import the actual function from its source file and test that import. Example:
import { safeCompare } from '../src/lib/crypto'
// then test safeCompare directlyAlso fix:
- Add
"test": "vitest run"toscriptsinpackage.json - Add
vitest.config.tswithresolve.alias: { '@': path.resolve(__dirname, 'src') } - Add EOF newline to test file
a266f00 to
d7d1a32
Compare
|
Deployment failed with the following error: |
Closes #768.
Summary of What Has Been Done:
Added test/github-webhook.test.ts with 20 vitest tests covering the signature verification logic from src/app/api/webhooks/github/route.ts.
Changes Made:
New file: test/github-webhook.test.ts
Test coverage:
Impact it Made:
All 20 tests pass. Webhook endpoint timing-safe comparison and HMAC verification validated.