Skip to content

test : added unit tests for GoalTracker component#791

Open
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#771
Open

test : added unit tests for GoalTracker component#791
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#771

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

Closes #771.

Summary of What Has Been Done:
Added test/GoalTracker.test.ts with 24 vitest tests covering the GoalTracker component's data handling and validation logic.

Changes Made:
New file: test/GoalTracker.test.ts

Test coverage:

  • handleCreate validation: title trim, empty/whitespace rejection, 100-char limit boundary, valid goal submission, server error handling
  • ConfettiBurst trigger: milestone completion at 100% only, progress percentage capped at 100%
  • getCompletionLabel: correct labels for one-time/weekly/monthly goals at completion
  • DELETE confirmation: optimistic removal, correct endpoint construction, failed DELETE rollback
  • RECURRENCE_LABELS mapping: all three recurrence types (none/weekly/monthly) correctly mapped

Impact it Made:
All 24 tests pass. Goal creation validation and milestone detection validated for the GoalTracker component.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests must import from source — not reimplement the function locally.

The test file re-implements the function being tested inside the test itself. This defeats the purpose of testing — changes to the real implementation won't fail these tests.

Fix: import the actual function from its source file and test that import. Example:

import { safeCompare } from '../src/lib/crypto'
// then test safeCompare directly

Also fix:

  • Add "test": "vitest run" to scripts in package.json
  • Add vitest.config.ts with resolve.alias: { '@': path.resolve(__dirname, 'src') }
  • Add EOF newline to test file

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #771 branch 3 times, most recently from 4d974ed to 66c7182 Compare May 23, 2026 14:59
Test User added 2 commits May 23, 2026 20:53
Closes Priyanshu-byte-coder#771

Added test/GoalTracker.test.ts covering:
- handleCreate validation: title trim, empty/whitespace rejection, 100-char limit, valid submission
- ConfettiBurst trigger: milestone completion at 100% (not 25/50/75%), progress percentage capped at 100%
- getCompletionLabel: correct labels for one-time/weekly/monthly goals
- DELETE confirmation: optimistic update, correct endpoint, failed DELETE rollback
- RECURRENCE_LABELS: all three recurrence types mapped correctly

Impact: All 24 tests pass. Goal creation validation and milestone detection validated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for GoalTracker component

2 participants