Skip to content

test : added unit tests for getRedisClient lazy initialization#796

Open
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#776
Open

test : added unit tests for getRedisClient lazy initialization#796
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#776

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

Closes #776.

Summary of What Has Been Done:
Added test/getRedisClient.test.ts with 4 vitest tests covering the getRedisClient lazy initialization from src/lib/metrics-cache.ts.

Changes Made:
New file: test/getRedisClient.test.ts

Test coverage:

  • Returns null when UPSTASH_REDIS_REST_URL is not set
  • Returns null when UPSTASH_REDIS_REST_TOKEN is not set
  • Returns Redis instance when both env vars are set
  • Returns same singleton instance on repeated calls (cache behavior)

Impact it Made:
All 4 tests pass. Redis client initialization validated.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@tmdeveloper007 tmdeveloper007 force-pushed the #776 branch 2 times, most recently from bb799c3 to 6d37816 Compare May 23, 2026 04:30
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import pattern is correct — function imported from source. Three infrastructure issues to fix before merge:

  1. Missing "test": "vitest run" in package.json scripts — tests can't run in CI without this.
  2. vitest.config.ts missing resolve.alias@/lib/* path aliases fail without:
import path from 'path'
export default defineConfig({
  resolve: { alias: { '@': path.resolve(__dirname, 'src') } },
  test: { globals: true }
})
  1. Missing EOF newline on test file.

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #776 branch 2 times, most recently from ffb3e22 to cf3ebb1 Compare May 23, 2026 14:59
Test User added 2 commits May 23, 2026 20:53
Closes Priyanshu-byte-coder#776

Added test/getRedisClient.test.ts covering:
- Returns null when UPSTASH_REDIS_REST_URL is not set
- Returns null when UPSTASH_REDIS_REST_TOKEN is not set
- Returns Redis instance when both env vars are set
- Returns same singleton instance on repeated calls (cache behavior)

Impact: All 4 tests pass. Redis client lazy initialization validated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for getRedisClient lazy initialization

2 participants