Skip to content

test : added unit tests for Goals POST validation logic#800

Open
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#780
Open

test : added unit tests for Goals POST validation logic#800
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#780

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

Closes #780.

Summary of What Has Been Done:
Added test/goals-api-validation.test.ts with 22 vitest tests covering the POST /api/goals endpoint validation logic.

Changes Made:
New file: test/goals-api-validation.test.ts

Test coverage:

  • Title validation: empty/whitespace rejection, 100-char limit boundary, valid non-empty title, non-string rejection
  • Target validation: min (1) and max (10000) boundaries, non-integer rejection, non-number rejection, valid cases
  • safeUnit: max 30-character slice, 'commits' default for non-string, empty string handling
  • safeRecurrence: valid values (none/weekly/monthly), invalid values fall back to 'none'
  • getPeriodStart: weekly (Monday), monthly (1st of month), none (epoch/never resets)

Impact it Made:
All 22 tests pass. Goal creation validation validated across all numeric and string constraints.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@tmdeveloper007 tmdeveloper007 force-pushed the #780 branch 2 times, most recently from 2a2a029 to f0931de Compare May 23, 2026 04:30
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests must import from source — not reimplement the function locally.

The test file re-implements the function being tested inside the test itself. This defeats the purpose of testing — changes to the real implementation won't fail these tests.

Fix: import the actual function from its source file and test that import. Example:

import { safeCompare } from '../src/lib/crypto'
// then test safeCompare directly

Also fix:

  • Add "test": "vitest run" to scripts in package.json
  • Add vitest.config.ts with resolve.alias: { '@': path.resolve(__dirname, 'src') }
  • Add EOF newline to test file

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #780 branch 3 times, most recently from ba23656 to c5a38a2 Compare May 23, 2026 14:59
Test User added 2 commits May 23, 2026 20:53
Closes Priyanshu-byte-coder#780

Added test/goals-api-validation.test.ts covering:
- Title validation: empty, whitespace-only, 100-char limit, boundary, non-string rejection
- Target validation: min/max boundaries, non-integer, non-number, valid cases
- safeUnit: max 30-char slice, default for non-string, empty string handling
- safeRecurrence: valid values (none/weekly/monthly), invalid values fallback to none
- getPeriodStart: weekly (Monday), monthly (1st), none (epoch)

Impact: All 22 tests pass. Goal creation validation validated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for Goals POST validation logic

2 participants