fix: user settings PATCH treats null body values as field omission#842
fix: user settings PATCH treats null body values as field omission#842tmdeveloper007 wants to merge 1 commit into
Conversation
|
@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
a3ffd70 to
68d0a46
Compare
Priyanshu-byte-coder
left a comment
There was a problem hiding this comment.
Two issues:
-
Missing EOF newline on
e2e/landing.spec.js. -
Null allowed into boolean field: Changing guards from
typeof is_public === 'boolean'tois_public !== undefinedallows{ is_public: null }through —nullwill be assigned to a typed boolean column. Change tois_public !== undefined && is_public !== nullto properly handle field omission vs explicit null.
|
Three issues block this merge: 1. Same problem with 2. Merge conflict 3. Missing EOF newline in |
500ae7b to
246b18a
Compare
|
Deployment failed with the following error: |
|
This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀 |
fix: user settings PATCH treats null body values as field omission