Skip to content

test : add unit tests for metricsCacheKey param serialization edge cases#849

Open
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#826
Open

test : add unit tests for metricsCacheKey param serialization edge cases#849
tmdeveloper007 wants to merge 2 commits into
Priyanshu-byte-coder:mainfrom
tmdeveloper007:#826

Conversation

@tmdeveloper007
Copy link
Copy Markdown
Contributor

Closes #826.

Summary of What Has Been Done:
Added edge case tests for metricsCacheKey param serialization to the existing metrics-cache.test.ts.

Changes Made:
Modified: test/metrics-cache.test.ts

Added tests:

  • null param values are correctly filtered out (not included in key)
  • undefined param values are correctly filtered out
  • numeric zero (0) is included as '0' in key
  • empty string is included as '' in key

Impact it Made:
Validates edge case param serialization. Catches any future regression in null/undefined filtering.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 23, 2026

@TESTPERSONAL is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:feature GSSoC type bonus: new feature type:testing GSSoC type bonus: tests (+10 pts) labels May 23, 2026
@github-actions
Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@tmdeveloper007 tmdeveloper007 force-pushed the #826 branch 2 times, most recently from 1aa538f to 4cfd47c Compare May 23, 2026 05:51
Copy link
Copy Markdown
Owner

@Priyanshu-byte-coder Priyanshu-byte-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import pattern is correct — function imported from source. Three infrastructure issues to fix before merge:

  1. Missing "test": "vitest run" in package.json scripts — tests can't run in CI without this.
  2. vitest.config.ts missing resolve.alias@/lib/* path aliases fail without:
import path from 'path'
export default defineConfig({
  resolve: { alias: { '@': path.resolve(__dirname, 'src') } },
  test: { globals: true }
})
  1. Missing EOF newline on test file.

@Priyanshu-byte-coder Priyanshu-byte-coder added gssoc:approved GSSoC: PR approved for scoring level:beginner GSSoC: Beginner difficulty (20 pts) labels May 23, 2026
@tmdeveloper007 tmdeveloper007 force-pushed the #826 branch 2 times, most recently from ee7ae2b to 51aacdd Compare May 23, 2026 14:51
@tmdeveloper007
Copy link
Copy Markdown
Contributor Author

This pull request is fully up-to-date with the latest upstream merges, all review items are addressed, local tests are passing cleanly, and it is fully ready to be merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved GSSoC: PR approved for scoring gssoc26 GSSoC 2026 contribution level:beginner GSSoC: Beginner difficulty (20 pts) type:feature GSSoC type bonus: new feature type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test : add unit tests for metricsCacheKey param serialization

2 participants