Draft
Conversation
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
for more information, see https://pre-commit.ci
Collaborator
|
Thanks for the updates, looking forward to seeing the complete updates. |
Collaborator
|
Hi @KumoLiu , Any update here? Thanks. |
Collaborator
Author
|
Hi @Nic-Ma, I don't have any update for this PR so far. The initial goal of this PR was to document what I thought could be improved in this model when I measured lazy resampling. However, because the data contained within this model zoo is actually high resolution, I was testing it on low resolution. So I'm just putting this PR here as a reference. If you think we need to keep updating it, I may need to redo some high-resolution experiments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While testing the lazy-resampling benchmark, I find that maybe there's room for improvement in the pre-processing.
In this PR, I mainly update several places below:
NormalizeIntensitydsince zeros aren't the background in the CTScaleIntensitydin front of theCropForegroundand change the value to 0-1 since we can only pad zero now in the lazy mode.AsDiscretedwhich may save memoryNote: the config was only tested on low resolution
cc @tangy5 @wyli
Status
Work in progress
Please ensure all the checkboxes:
./runtests.sh --codeformat.versionandchangeloginmetadata.jsonif changing an existing bundle.CONTRIBUTING.md).monai,pytorchandnumpyare correct inmetadata.json.eval_metricsof the provided weights and TorchScript modules.large_file.yml./home/your_name/for"bundle_root").