Skip to content

raise a ValueError when user tries to delete an unexisting transform #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gautzilla merged 1 commit into from
May 12, 2026
+8 −0
Merged

raise a ValueError when user tries to delete an unexisting transform #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/osekit/public/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,10 @@ def delete_transform_with_outputs(self, transform_name: str) -> None:
Name of the transform whose output to delete.

"""
if transform_name not in self.transforms:
message = f"Transform '{transform_name}' not found."
raise ValueError(message)

for dataset_to_delete in self.get_output_by_transform_name(
transform_name,
):
Expand Down
4 changes: 4 additions & 0 deletions tests/test_public_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,6 +1397,10 @@ def test_delete_output(
assert all(ds.name in proj.outputs.keys() for ds in datasets_to_keep)
assert not any(ds.name in proj.outputs.keys() for ds in datasets_to_delete)

# Trying to delete an unexisting transform should raise:
with pytest.raises(ValueError, match="'FrankieCosmos'"):
project.delete_transform_with_outputs("FrankieCosmos")


def test_existing_output_warning(
tmp_path: pytest.fixture,
Expand Down