refactor to avoid need for missing smarty abs#502
Merged
dontub merged 2 commits intoProject60:masterfrom Apr 2, 2026
Merged
Conversation
Contributor
Author
|
I tried to assuage CodeSniffer - I think it's progress though there seem to be a lot of pre-existing bits it takes issue with.. |
dontub
requested changes
Feb 13, 2026
Collaborator
dontub
left a comment
dontub
left a comment
There was a problem hiding this comment.
Thanks for the PR. I made some comments how to fix phpstan errors.
dontub
added
status:needs work
Contributor
|
Commit works well in v1.4.0, thank you very much @ufundo |
jensschuppe
added
status:fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #474
Do the juggling in the PHP pre-smarty.