Skip to content

Quest Added #High Standards#186

Open
epinephren wants to merge 5 commits intoPunishXIV:new-mainfrom
epinephren:new-main
Open

Quest Added #High Standards#186
epinephren wants to merge 5 commits intoPunishXIV:new-mainfrom
epinephren:new-main

Conversation

@epinephren
Copy link

No description provided.

Copy link
Collaborator

@alydevs alydevs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission. I'll check the flags for The Life of the Party and edit those in your PR, and I can see about renaming the files to the correct IDs i.e -65536. If I'm able to check these, I'll add the LastChecked value myself, otherwise if you ran the paths successfully please add that yourself. Please wait for me or Kiarra to approve and merge this. Thanks again for the sidequests.

@@ -0,0 +1,78 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quest IDs in the filename are incorrect, the row ID for quests in their sheet has 65536 added, use the Copy Filename button in future to get the right one or calculate -65536

"TerritoryId": 147,
"InteractionType": "UseItem",
"ItemId": 2000789,
"CompletionQuestVariablesFlags": [null,null,null,null,null,64]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CompletionQuestVariablesFlags can't have the same value checked more than once in a given sequence, this suggests it was copied from elsewhere without fully understanding what it's checking. I'll see if I can take this quest and fix these values in your PR

@@ -0,0 +1,68 @@
{
"$schema": "https://qstxiv.github.io/schema/quest-v1.json",
"Author": "epinephren@github",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When submitting a quest path, please abandon and reaccept the quest and run your path from start to finish with "Prevent Quest Completion" checked in qst settings > Advanced. If the quest runs through to CompleteQuest with no issues, add "LastChecked": {"Username": "name", "Date": "yyyy-mm-dd"}, below the Author line. This is a new proof standard I'm implementing to add some accountability to our path database.

{
"EnemySpawnType": "OverworldEnemies",
"Position": {
"XX": 130.14093,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"XX" isn't right, please use the copied position data from the "Copy position as JSON" button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants