Open
Conversation
Two bugs fixed: 1. conference-data.ts: Concurrent calls to load() each created separate HTTP requests. Added shareReplay() and loadObservable caching so all concurrent subscribers share one execution. Removed the dangerous this.data = null reset before processData(). Cleared in-flight observable on complete/error for proper retry on failure. 2. schedule.ts: hasData was only set in reloadSchedule() but updateSchedule() (called on every tab show, filter, search) never set it. Added hasData = true in updateSchedule()'s getTimeline callback so the "not loaded" error clears even if the initial reloadSchedule() path failed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
Author
|
needs review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two compounding bugs that caused the schedule to intermittently show "Schedule not loaded" despite working network:
Race condition in
load()— concurrent calls each created separate HTTP requests. Now usesshareReplay()so all subscribers share one execution. Removed dangerousthis.data = nullreset mid-flight.hasDatanever set inupdateSchedule()— the "not loaded" error was controlled byhasDatawhich was only set inreloadSchedule(). If that initial path failed, subsequent successful loads viaupdateSchedule()(tab show, filter, search) still showed the error. Now setshasData = truein the timeline callback.Test plan
🤖 Generated with Claude Code