Merged
Conversation
| - ``pressure`` --- target area-averaged static pressure on the | ||
| boundary. Also used as the initial Riemann invariant pressure. | ||
|
|
||
| *float* | *string* |
Contributor
Author
There was a problem hiding this comment.
It is evaluated with _eval_opts so it can be an expression/string that is then evaluated
Contributor
|
Are you able to do a final test? |
Contributor
Author
There was a bug where the np.void type that is used for sdata doesn't support slice indexing. Now everything works in my tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rebases @pv101 pressure controller PR #533 onto the head of develop with some refactoring. I don't have access rights to the original PR's branch, hence the new PR.