Skip to content

release: 0.28.3#5929

Merged
davidhewitt merged 10 commits intorelease-0.28from
release-0.28.3
Apr 2, 2026
Merged

release: 0.28.3#5929
davidhewitt merged 10 commits intorelease-0.28from
release-0.28.3

Conversation

@davidhewitt
Copy link
Copy Markdown
Member

@davidhewitt davidhewitt commented Mar 31, 2026

Backports for an upcoming 0.28.3 release.

Will wait until #5928 is resolved (to cherry-pick it here) and then I think we're ready to ship this set of fixes.

maurosilber and others added 4 commits March 31, 2026 10:37
@maurosilber @davidhewitt
fix(pyo3-macros): allow pyclass named Probe (#5837)
e57430f 
The `*` import was shadowing the name of the pyclass.

The PyMethods trait was only defined for the multiple-pymethods feature,
but it cannot be conditionally imported inside the macro.
I just defined the trait unconditionally.

Fixes #4792.
@Embers-of-the-Fire @davidhewitt
[fix] Fix std::ffi import for _Py_NegativeRefcount (#5847)
24a131f 
* fix: update type import cfg

* add: add newsfragments
@alex @davidhewitt
fixes #5900 -- address race condition with initialization and site.py…
d473969 
… loading (#5903)

* fixes #5900 -- address race condition with initialization and site.py loading

* Use call_once since wait requires a higher MSRV

* Update src/interpreter_lifecycle.rs

Co-authored-by: David Hewitt <mail@davidhewitt.dev>

---------

Co-authored-by: David Hewitt <mail@davidhewitt.dev>
@bschoenmaeckers @Icxolu @davidhewitt
Fix unsoundness in PyBytesWriter::write_vectored (#5907)
7a34567 
* Fix unsoundness in `PyBytesWriter::write_vectored`

* Add testcase

* Update safety comment on `PyBytesWriter::set_len`

* Apply suggestion

Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>

---------

Co-authored-by: Icxolu <10486322+Icxolu@users.noreply.github.com>
@davidhewitt davidhewitt changed the title Release 0.28.3 release: 0.28.3 Mar 31, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026 •
edited
Loading

Merging this PR will degrade performance by 21.15%

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 97 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ extract_int_extract_fail 9.2 µs 8.2 µs +12.12%
❌ list_get_item_unchecked 3.3 ms 4.2 ms -21.15%
❌ drop_many_objects 14.6 µs 17.5 µs -16.36%

Comparing release-0.28.3 (492eba7) with release-0.28 (c700b5d)1

Open in CodSpeed

Footnotes

  1. No successful run was found on release-0.28 (2b392c8) during the generation of this report, so 5b8c62e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Icxolu and others added 4 commits March 31, 2026 13:04
@Icxolu @davidhewitt
remove unused try_trait_v2 feature when enabling the nightly feat…
167fa67 
…ure (#5868)
@ngoldbaum @davidhewitt
fix ffi-check in 3.15.0a7 (#5873)
08bc83d
@chirizxc @davidhewitt
Update getting-started.md (#5899)
1a61500
@davidhewitt
ci: update UI tests for Rust 1.94 (#5859)
f2992d7 
* update UI tests for Rust 1.94

* ci: debug windows introspection failure

* check path for failed object

* ensure file path for `test-introspection` is correct
@davidhewitt
fix deadlock when initializing enum via into_pyobject() (#5928)
24eb4c0 
* fix deadlock when initializing enum via `into_pyobject()`

* newsfragment

* fix `unreachable_code` failure
@davidhewitt davidhewitt marked this pull request as ready for review March 31, 2026 16:51
bschoenmaeckers
bschoenmaeckers approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@bschoenmaeckers bschoenmaeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!🙏

@ngoldbaum
Copy link
Copy Markdown
Contributor

ngoldbaum commented Mar 31, 2026

Think we should backport #5917 as well?

@bschoenmaeckers
Copy link
Copy Markdown
Member

bschoenmaeckers commented Apr 1, 2026

Think we should backport #5917 as well?

You're right! That would also need the fix in #5918 as well

@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Apr 1, 2026

I actually deliberately skipped #5917 because it could break existing compiles. Thought it's probably best to defer that to 0.29.0, which probably means we should aim to ship that before too long.

I'll try to get this shipped later today, sorry for the delay, ran out of energy yesterday evening and dropped the ball on a few different things.

@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Apr 1, 2026

(force pushed to update release date to today, will merge after CI and release)

@davidhewitt
Copy link
Copy Markdown
Member Author

davidhewitt commented Apr 2, 2026

I fell asleep before CI finished running yesterday - need to get more optimizations landed 😅

@davidhewitt davidhewitt merged commit 743af64 into release-0.28 Apr 2, 2026
89 of 91 checks passed
@davidhewitt davidhewitt deleted the release-0.28.3 branch April 2, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bschoenmaeckers bschoenmaeckers bschoenmaeckers approved these changes

Assignees

No one assigned

Labels

CI-build-full

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@davidhewitt @ngoldbaum @bschoenmaeckers @maurosilber @Embers-of-the-Fire @alex @Icxolu @chirizxc