fix: make assert_linequal term-order invariant#640
Closed
FBumann wants to merge 1 commit intoperf/matrix-accessor-rewritefrom
Closed
fix: make assert_linequal term-order invariant#640FBumann wants to merge 1 commit intoperf/matrix-accessor-rewritefrom
FBumann wants to merge 1 commit intoperf/matrix-accessor-rewritefrom
Conversation
Sort both sides by variable labels along _term before comparing, so expressions with different term orderings (e.g. from CSR round-trip with freeze_constraints=True) are correctly recognized as equal. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
Closed in favor of #639 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_linequalnow sorts both sides by variable labels along_termbefore comparing, so expressions with different term orderings are correctly recognized as semantically equal.freeze_constraints=True) against freshly built expressions, sincecsr.sum_duplicates()sorts terms by variable label.Reproducer (from #630 comment)
Test plan
Replaces #639 (was opened from fork, CI didn't trigger fully).
🤖 Generated with Claude Code