feat: Iterate possible iot domains on 3030 error

[Ongy]

This error is returned by Roborock's API when there is an account currently in deletion.
This can happen e.g. if a user erronously creates their account in the wrong region and then deletes it so they can create a new one in the correct region.

[Ongy]

I'll have to figure out how to best test this against real data, so I'll leave it in draft mode for now as RFC.

[Ongy]

ok yea, testing failed. This call isn't hte one that fails.

[Lash-L]

Hi @Ongy! Thanks for taking a stab at this! You should be able to test this using the aioresponses patches we do.

Looks like your issue is with:

_LOGGER.warning("Found account in deletion in %s (code %s)", country, country_code)

country and country code are not set here yet.

[Ongy]

Yea, no. It's the entirely wrong point to do this.
In this iteration, every baseurl returns something useful (testing with curl).
For me (deleted account in the US, existing one in EU):

• usiot => us
• euiot => eu
• ruiot => eu
• cniot => eu

So we'd have to build a list here, and then do this error handling and iteration at login time :/
Which I think (for my usecase) round trips through HA, which will add some extra pain to get this right

[Lash-L]

Do you get the error at the point of requesting the code or at the point of submitting the code?

[Ongy]

Pretty sure it's in the request.
Which is in the same file and just uses itself. So it shouldn't be too hard to make it iterate.

My python is rusty, so I don't always see how things flow immediately

2026-01-02 12:39:06.276 ERROR (MainThread) [homeassistant.components.roborock.config_flow] Unexpected exception
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/roborock/config_flow.py", line 85, in _request_code
    await self._client.request_code_v4()
  File "/usr/local/lib/python3.13/site-packages/roborock/web_api.py", line 273, in request_code_v4
    raise RoborockException(f"{code_response.get('msg')} - response code: {code_response.get('code')}")
roborock.exceptions.RoborockException: user account is in deletion - response code: 3030
2026-01-02 12:39:15.750 ERROR (MainThread) [homeassistant.components.roborock.config_flow] Unexpected exception
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/roborock/config_flow.py", line 85, in _request_code
    await self._client.request_code_v4()
  File "/usr/local/lib/python3.13/site-packages/roborock/web_api.py", line 273, in request_code_v4
    raise RoborockException(f"{code_response.get('msg')} - response code: {code_response.get('code')}")
roborock.exceptions.RoborockException: user account is in deletion - response code: 3030
2026-01-02 12:39:30.557 ERROR (MainThread) [homeassistant.components.roborock.config_flow] Unexpected exception
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/roborock/config_flow.py", line 85, in _request_code
    await self._client.request_code_v4()
  File "/usr/local/lib/python3.13/site-packages/roborock/web_api.py", line 273, in request_code_v4
    raise RoborockException(f"{code_response.get('msg')} - response code: {code_response.get('code')}")
roborock.exceptions.RoborockException: user account is in deletion - response code: 3030

[Lash-L]

Okay cool! Better case for us than if it were in the submit code.

I think the best way to handle it to keep it easy on the caller(i.e. HA) is:

1. In request code v4 handle the error.
2. on account in deletion error - call _get_iot_login_info again, but this time add in logic so that it can exclude one or multiple regions.
3. recursively return self._request_code_v4

Basically make request_code_v4 be responsible for handling this edge case and resolving it automatically.

[Ongy]

do you squash commits on merge or should I clean up history a bit?

[Ongy]

sorry for the unformatted/unlinted state. I don't know how to run the tooling locally :/

[Ongy]

Oh, also haven't tested this against a real environment. Only the automated test I added.

If there's some easy way to test in real, please give a commandline :)

[allenporter]

The two options are:
(1) use the CLI roborock ... and modify as needed if the current login flow doesn't do what is needed
(2) use Home Assistant (a) https://developers.home-assistant.io/docs/development_environment and then (b)

[Ongy]

ok, so the code works but the local rate limiter kills it because it tries to login too quickly.

Would you prefer to place the loop/recursion in a place that only grabs the rate limit before its entered or rather to add the url into the key for the rate limit?

[Lash-L]

thoughts @allenporter ?

We definitely want to make sure we aren't spamming request_code

I'm not sure if you can move the limiter somewhere that would be okay. so in my mind there are two options:

1. Raise rate limit to 2. If it is 2, it should be fine so long as the user only has a deleted account in one other region.
2. Make the limiter bucket be region specific. This is kind of a bigger change and i'm not sure if it is worth the extra complexity.

[allenporter]

My suggestion would be to not try to fight against rate limiting. If it's being hit it probably means we should rethink our appraoch.

Given that roborock asks the user for their country/region in the app setup, and it effectively creates these silos, i think it may be worth just asking the user for the region in the setup flow. Is that an option?

[Lash-L]

My suggestion would be to not try to fight against rate limiting. If it's being hit it probably means we should rethink our appraoch.

Given that roborock asks the user for their country/region in the app setup, and it effectively creates these silos, i think it may be worth just asking the user for the region in the setup flow. Is that an option?

Yeah I'm fine with this and it is probably the way forward, but it is not ideal.

We should default to auto functionality (where this logic may still be helpful for one retry)

But the regions are unfortunately not as clear as you would hope. Some random countries were in US and some were in EU region that you wouldn't expect for both. I was not aware of a list or anyway to determine what countries are in what regions easily. So users will likely get confused for what region they should select when there is no region that matches their country well.

[Ongy]

So there's one thing I don't quite understand.

Why do we even get an exception instead of blocking for a second? From the docs in https://github.com/vutran1710/PyrateLimiter?tab=readme-ov-file#blocking-vs-non-blocking I'd assume that we should block here.
I think waiting the second is ok. The minute for 3 would start to be painful, so I was thinking of doing that with a timeout.
Additional confusion though, when I try to add the timeout as described I get an unexpected keyword error.

[Ongy]

Found it. the default allowed amount to wait is 50ms, so I upped it to 1s (and made sure to switch to the _async api for that bucket) which now works.

Should work for up to 3 attempts, then the code will hit the per-minute limit.

[Copilot]

Pull request overview

This PR adds functionality to handle error code 3030 from Roborock's API, which occurs when an account is currently in deletion. The implementation allows the client to iterate through possible IoT domains when this error is encountered, enabling users who have deleted accounts in one region to successfully authenticate in another region.

Changes:

• Modified request_code_v4 to detect 3030 errors and retry with the next available IoT domain
• Converted login rate limiter from synchronous to asynchronous and added max_delay parameter
• Added _base_urls instance variable to track available URLs for iteration
• Added comprehensive test case test_thirty_thirty_cycling to verify the new behavior

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
roborock/web_api.py	Implements 3030 error handling with domain iteration, converts rate limiter to async, adds _base_urls tracking
tests/test_web_api.py	Adds test for 3030 cycling behavior, minor comment formatting fix

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Debug print statement should be removed before merging. This appears to be leftover from development/debugging.

Suggested change

print(mock_rest.requests)

[Lash-L]

Yep please remove this print!