Pullbacks for Diagonal inputs
#156
Open
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
FWIW there was some work done for this in the |
Member
|
So you might be able to cannibalize part of that |
Member
Author
|
Ahh, thanks! let me first revisit that then :) |
Member
|
Just grab whatever you need from there imo and I can rebase on top of this once it's merged |
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
lkdvos
force-pushed
the
ld-diagpullback
branch
from
de0c3b6 to
48fe1a9
Compare
kshyatt
force-pushed
the
ld-diagpullback
branch
from
48fe1a9 to
be7d543
Compare
kshyatt
reviewed
Jan 19, 2026
| degeneracy_atol::Real = default_pullback_rank_atol(DV[1]), | ||
| gauge_atol::Real = default_pullback_gauge_atol(ΔDV[2]) | ||
| ) | ||
| ΔA_full = zero!(similar(ΔA, size(ΔA))) |
Member
There was a problem hiding this comment.
Oof, this might become a lot of allocations for large diagonals... Is there no way for us to write a little more sophisticated rule that only computes the diagonal components of ΔA_full?
Member
There was a problem hiding this comment.
Is A itself also Diagonal? In that case, I think we have ΔA = ΔD. The contribution from ΔV` should be completely off-diagonal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into some issues in QuantumKitHub/TensorKit.jl#350, we are currently not testing pullbacks for$\Delta A$ , but we need an additional projection on the diagonal subspace.
Diagonalinputs, and apparently this is not working right now.The issue is that we want to in-place add to
I'm guessing similar issues would appear for other restricted input vector spaces, for now I'd be okay with this simple fix only for diagonal.
I'll try add a similar thing for the other pullbacks as well. In principle we can probably improve the performance a bit more but I'm not sure if this is worth the effort.